Skip to content

feat(helm): new chart design #4437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SkalaNetworks
Copy link
Contributor

This PR is about issue #4330

This is a draft, it shouldn't change any resource name as to not break existing installations, but if someone wants to update using the Helm Chart, they'll obviously have to adapt their values.

@SkalaNetworks
Copy link
Contributor Author

Note that I have no clue what the difference is between DPDK and DPDK-hybrid, the DPDK docs only mention the hybrid version as far as I know

@oujonny
Copy link
Contributor

oujonny commented Dec 5, 2024

hey @SkalaNetworks what's the state of the PR?

@SkalaNetworks
Copy link
Contributor Author

Hey @oujonny , It's pretty much a fully ready Helm Chart, I need to integrate the changes that have been done to the original in this PR too and put back the labels that are matched by the CLI.

We actually use this chart in production.

The thing is, the changes in values make the 2 charts completely incompatible. So rolling out this chart needs a notice on how to migrate values and a deprecation notice of the old chart.

I'll update the chart with new changes shortly

Copy link
Contributor

PRs go stale after 60d of inactivity. Please comment or re-open the PR if you are still working on this PR.

@SkalaNetworks
Copy link
Contributor Author

Hey @zhangzujian, do you have an opinion on what we can do with this "new" Helm chart? I say new considering it's kind of a breaking change, users need to adapt their values to the chart. The work isn't even finished, a lot of work could be done to make the values prettier.

I tried not to change them too much as not to kill clusters if someone tries to upgrade their chart to mine, but it is far from a guarantee.

Maybe release this chart as a V2 alongside the first one and slowly transition to it? It should be easier to maintain as I tried to follow Helm best practices and the standard Helm structure.

I'm starting to work a bit more on network stuff that relates to Kube-OVN so I'll continue modifying the chart pretty much weekly.

@zhangzujian
Copy link
Member

Maybe release this chart as a V2 alongside the first one and slowly transition to it? It should be easier to maintain as I tried to follow Helm best practices and the standard Helm structure.

I think a new v2 version would be better. We can deprecate the current version and remove it in the future.

Signed-off-by: SkalaNetworks <[email protected]>
@SkalaNetworks
Copy link
Contributor Author

What's left to do:

  • automate the doc generation
  • make a nicer readme

Signed-off-by: SkalaNetworks <[email protected]>
Signed-off-by: SkalaNetworks <[email protected]>
@SkalaNetworks SkalaNetworks marked this pull request as ready for review April 14, 2025 11:58
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. chart Helm Chart labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart Helm Chart size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants