Skip to content

chart version equal to 1.0#5417

Merged
changluyi merged 2 commits intorelease-1.14from
equal_chart_version_to_1.0
Jul 15, 2025
Merged

chart version equal to 1.0#5417
changluyi merged 2 commits intorelease-1.14from
equal_chart_version_to_1.0

Conversation

@changluyi
Copy link
Copy Markdown
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: clyi <clyi@alauda.io>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @changluyi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor but important metadata update within the kube-ovn-v2 Helm chart. The primary purpose is to synchronize the chart's own version number with the application version it deploys, ensuring consistency and clarity in release management. While the PR title suggests a change to '1.0', the actual patch updates the version to v1.14.0.

Highlights

  • Helm Chart Version Update: I've updated the version field in the charts/kube-ovn-v2/Chart.yaml file from 2.0.0 to v1.14.0. This change aligns the chart's version with its appVersion, which is already set to 1.14.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the chart Helm Chart label Jul 2, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to align the Helm chart version with the application version. The PR title, "chart version equal to 1.0", seems to be a typo given the changes.

I've found one issue in Chart.yaml where the new version string is not a valid Semantic Version, which can cause problems with Helm tooling. I've left a suggestion to fix this to ensure chart correctness and maintainability.

Comment thread charts/kube-ovn-v2/Chart.yaml Outdated
@changluyi changluyi requested a review from oilbeater July 2, 2025 03:52
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 2, 2025

Pull Request Test Coverage Report for Build 16039263297

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 21.562%

Files with Coverage Reduction New Missed Lines %
pkg/ovs/ovn-nb-port_group.go 2 76.19%
Totals Coverage Status
Change from base Build 16021955795: 0.0%
Covered Lines: 10505
Relevant Lines: 48720

💛 - Coveralls

@changluyi changluyi closed this Jul 2, 2025
@changluyi changluyi reopened this Jul 2, 2025
Signed-off-by: clyi <clyi@alauda.io>
@changluyi changluyi requested a review from SkalaNetworks July 4, 2025 01:13
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2025
@changluyi changluyi merged commit bf67027 into release-1.14 Jul 15, 2025
98 of 102 checks passed
@changluyi changluyi deleted the equal_chart_version_to_1.0 branch July 15, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart Helm Chart lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants