controller: set always_learn_from_arp_request to false only when LR is not connected to external network

[zhangzujian]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features
• Bug fixes
• Docs
• Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Summary of Changes

Hello @zhangzujian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug by refining how OVN logical router options are configured for VPCs. Specifically, it prevents the mac_binding_age_threshold from being set on VPCs that are connected to an external network, ensuring more appropriate network behavior based on the VPC's connectivity type.

Highlights

• Conditional MAC Binding Age: The mac_binding_age_threshold option for OVN logical routers is now conditionally applied. It will only be set when a VPC is not configured to be connected to an external network.
• Function Signature Update: The createVpcRouter function in pkg/controller/vpc.go has been updated to accept an enableExternal boolean parameter, which dictates whether the MAC binding age threshold should be applied.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the VPC controller to conditionally set OVN logical router options. Specifically, it avoids setting mac_binding_age_threshold and other related options when a VPC is connected to an external network. The changes are logical and correct. I've provided one suggestion to improve maintainability by extracting the hardcoded router options.

[coveralls]

Pull Request Test Coverage Report for Build 16044609411

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.001%) to 21.558%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/vpc.go	0	14	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/controller/vpc.go	1	0.0%

Totals
Change from base Build 16044085466:	0.001%
Covered Lines:	10512
Relevant Lines:	48761

---

💛 - Coveralls

[zhangzujian]

/gemini review

[gemini-code-assist]

Code Review

The pull request effectively addresses the objective of conditionally setting always_learn_from_arp_request based on whether the logical router is connected to an external network. The refactoring of createVpcRouter to accept the enableExternal parameter and the addition of the maps.Equal check before updating the logical router options are positive changes that improve both correctness and efficiency.

[gemini-code-assist]

The introduction of the if !maps.Equal(vpcRouter.Options, lrOptions) check is a valuable improvement. It ensures that the OVN logical router is only updated when its options have genuinely changed, preventing redundant OVSDB transactions. This can lead to better performance and reduced load on the OVN control plane.

[zbb88888]

@zhangzujian 大佬，U2O 场景下会有同样的问题么？

[patriziobassi]

@zhangzujian this will not fix the case where we have a underlay network attached to the default vpc (for u2o) as that network will no be marked as external (no need for nat gw), so bug #5318 will not be fixed

[zhangzujian]

@patriziobassi This patch is NOT a fix for the problem you metioned above.