kubectl-ko: replace endpoint with endpointslice#5425
kubectl-ko: replace endpoint with endpointslice#5425zhangzujian merged 1 commit intokubeovn:masterfrom
Conversation
Signed-off-by: zhangzujian <[email protected]>
dosubot
bot
added
the
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @zhangzujian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the kubectl-ko utility script to migrate from the deprecated Kubernetes Endpoints API to the more modern EndpointSlice API. This change resolves deprecation warnings and ensures the script's continued functionality for checking OVN component leaders in Kubernetes environments.
Highlights
- API Deprecation Fix: The
kubectl-koscript has been updated to replace the deprecatedv1 EndpointsAPI with thediscovery.k8s.io/v1 EndpointSliceAPI. This addresses deprecation warnings and ensures future compatibility. - Leader Check Logic Update: The
checkLeaderfunction withindist/images/kubectl-konow useskubectl get endpointslicewith ajsonpathquery to correctly identify and count leader instances for OVN components (ovn-nb, ovn-sb, ovn-northd), adapting to the new EndpointSlice structure.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request replaces the deprecated Endpoints API with EndpointSlice for leader checks in the kubectl-ko script. The change improves compatibility with newer Kubernetes versions. The review focuses on ensuring the checkLeader function accurately counts active endpoints.
| component="$1"; shift | ||
| set +o pipefail | ||
| count=$(kubectl get ep ovn-$component -n $KUBE_OVN_NS -o yaml | grep "ip:" | wc -l) | ||
| count=$(kubectl get endpointslice -l kubernetes.io/service-name=ovn-$component -n $KUBE_OVN_NS -o jsonpath='{.items[*].endpoints[*].addresses[0]}' | sort | uniq | wc -l) |
There was a problem hiding this comment.
The current jsonpath command only retrieves the first address of each endpoint, which can lead to an inaccurate count of active endpoints. This can cause the leader election to fail if multiple endpoints are present but only one address is retrieved.[^1]
count=$(kubectl get endpointslice -l kubernetes.io/service-name=ovn-$component -n $KUBE_OVN_NS -o go-template='{{len .items}}')
Pull Request Test Coverage Report for Build 16044421755Details
💛 - Coveralls |
Signed-off-by: zhangzujian <[email protected]>
3 participants
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes