Skip to content

controller: fix lsp not deleted in gc#5735

Merged
zhangzujian merged 3 commits intokubeovn:masterfrom
zhangzujian:fix-lsp-gc
Sep 21, 2025
Merged

controller: fix lsp not deleted in gc#5735
zhangzujian merged 3 commits intokubeovn:masterfrom
zhangzujian:fix-lsp-gc

Conversation

@zhangzujian
Copy link
Copy Markdown
Member

@zhangzujian zhangzujian commented Sep 19, 2025

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

After upgrading kube-ovn to v1.14.6, some stale logical switch ports are not deleted in gc:

I0919 15:44:21.952382       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 15:47:24.083684       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 15:50:26.197093       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 15:53:28.168941       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 15:56:30.300947       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 15:59:32.394582       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 16:02:34.638748       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 16:05:36.632861       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
I0919 16:08:38.697615       7 gc.go:436] gc logical switch port acp-daemonset-m5wc5.e2eproject-acp-0-ns
...

It seems the libovsdb's Get() method does not return the logical switch port object and the deletion operation is skipped.

Currently I cannot figure not thre reason, so we need to avoid the problem by deleting logical switch ports by UUIDs.

@zhangzujian zhangzujian added bug Something isn't working need backport labels Sep 19, 2025
@zhangzujian zhangzujian marked this pull request as ready for review September 19, 2025 08:13
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 19, 2025
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian merged commit efd240f into kubeovn:master Sep 21, 2025
71 of 72 checks passed
@zhangzujian zhangzujian deleted the fix-lsp-gc branch September 21, 2025 03:21
zhangzujian added a commit that referenced this pull request Sep 21, 2025
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@OneWithoutName
Copy link
Copy Markdown

image image 升级到了1.14.15后,还是会出现残留的问题。

@zhangzujian
Copy link
Copy Markdown
Member Author

@OneWithoutName
Copy link
Copy Markdown

@OneWithoutName StatefulSet 不要使用 force delete:https://kubernetes.io/zh-cn/docs/tasks/run-application/force-delete-stateful-set-pod/

核对了下,这个pod没有使用force delete,而是通过scale replicas的操作,类似3->0,0->3这样的

@OneWithoutName
Copy link
Copy Markdown

我弄错了,我以为这个PR是解决#5724 这个bug的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer need backport size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants