fix gabage u2o openflow

[changluyi]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features
• Bug fixes
• Docs
• Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Summary of Changes

Hello @changluyi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug related to "garbage" OpenFlow rules in Underlay-to-Overlay (U2O) communication within Kube-OVN. The changes enhance the robustness of pod deletion handling by ensuring critical pod data is available during the cleanup process, preventing potential issues where OpenFlow rules might not be properly removed. Additionally, the logic for adding OpenFlow rules has been made more precise to avoid redundant entries. A new E2E test has been introduced to thoroughly validate these fixes and ensure the stability of U2O OpenFlow rule management.

Highlights

• Improved Pod Deletion Handling: Introduced a sync.Map to store pod objects during deletion, ensuring that handleDeletePod can access necessary pod information even if the pod is no longer in the lister, preventing issues with stale data and ensuring proper OpenFlow rule cleanup.
• Refined OpenFlow Rule Management: Updated the AddOrUpdateU2OKeepSrcMac function to perform a more precise check for existing OpenFlow rules, specifically verifying the mod_dl_src action, which prevents redundant rule additions and ensures only necessary rules are applied.
• New E2E Conformance Test: Added a comprehensive end-to-end test to validate the correct creation and deletion of keepSrcMac OpenFlow rules for U2O interconnection, covering pod lifecycle and u2oInterconnection status changes to prevent future regressions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a race condition during pod deletion that could lead to stale OpenFlow rules. The approach of caching the pod object at deletion enqueue time is robust. The change to make the OpenFlow rule existence check more specific is a good improvement, and the new end-to-end test provides excellent coverage for the fix. I have a couple of minor suggestions to further refine the code.

[gemini-code-assist]

The error returned by action.MarshalText() is being ignored. While errors might be rare for standard OpenFlow actions, it's safer to handle them to prevent unexpected behavior. Please consider checking the error and logging it if it's not nil.

actionText, err := action.MarshalText()
if err != nil {
	klog.Warningf("failed to marshal action from flow: %v", err)
	continue
}
if string(actionText) == expectedAction {
	klog.V(3).Infof("flow already exists in bridge %s for in_port=%d, ip_src=%s, dl_src=%s, actions=mod_dl_src:%s",
		bridgeName, localnetPatchPortID, podIP, chassisMac, podMac)
	return nil
}

[gemini-code-assist]

This time.Sleep is unnecessary. The subsequent call to checkKeepSrcMacFlow already uses framework.WaitUntil to poll for the expected state of the OpenFlow rules, making this explicit sleep redundant. Removing it will make the test slightly faster and more robust against timing variations.

[coveralls]

Pull Request Test Coverage Report for Build 18083704987

Details

• 0 of 28 (0.0%) changed or added relevant lines in 3 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.004%) to 21.084%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/daemon/controller_linux.go	0	8	0.0%
pkg/daemon/controller.go	0	10	0.0%
pkg/ovs/ovs-ofctl.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/ovs/ovn-nb-logical_router_route.go	2	74.6%

Totals
Change from base Build 17994370999:	-0.004%
Covered Lines:	10705
Relevant Lines:	50772

---

💛 - Coveralls