Skip to content

add e2e for networkpolicy lax mode#5800

Merged
oilbeater merged 1 commit intomasterfrom
np-enforcement-install
Oct 17, 2025
Merged

add e2e for networkpolicy lax mode#5800
oilbeater merged 1 commit intomasterfrom
np-enforcement-install

Conversation

@oilbeater
Copy link
Copy Markdown
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @oilbeater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option, NP_ENFORCEMENT, into the installation script. This variable allows for specifying different modes of network policy enforcement, defaulting to 'standard'. While the title suggests adding end-to-end tests for a 'lax mode', the current changes primarily lay the groundwork by providing the necessary configuration parameter.

Highlights

  • New Configuration Variable: Introduced a new environment variable, NP_ENFORCEMENT, to control network policy enforcement behavior.
  • Default Enforcement Mode: The NP_ENFORCEMENT variable is initialized with a default value of standard.
  • Script Argument Integration: The value of NP_ENFORCEMENT is now passed as an argument --np-enforcement within the install.sh script, allowing for dynamic configuration of network policy enforcement.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build-x86-image.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. network policy test automation tests labels Oct 17, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration option, np-enforcement, to allow setting the network policy enforcement mode to standard or lax. This is a valuable addition for environments like those using Kubevirt, where more permissive default network rules are beneficial. The changes are consistently applied across the installation script and Helm charts, passing the new configuration to the kube-ovn-controller. The implementation in the provided patch for dist/images/install.sh is correct and follows existing patterns. The changes look good and I have no further suggestions.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18580186469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 21.149%

Totals Coverage Status
Change from base Build 18554291225: 0.004%
Covered Lines: 10731
Relevant Lines: 50740

💛 - Coveralls

@oilbeater oilbeater merged commit 023eb9d into master Oct 17, 2025
127 of 140 checks passed
@oilbeater oilbeater deleted the np-enforcement-install branch October 17, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

network policy size:S This PR changes 10-29 lines, ignoring generated files. test automation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants