Skip to content

rever ovn version#5854

Closed
changluyi wants to merge 1 commit intomasterfrom
revert_ovn_commit_fix_migrate_error
Closed

rever ovn version#5854
changluyi wants to merge 1 commit intomasterfrom
revert_ovn_commit_fix_migrate_error

Conversation

@changluyi
Copy link
Copy Markdown
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 4, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @changluyi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the stability and reproducibility of the build process by pinning the OVN dependency to a specific commit. This change ensures that all builds utilize a consistent version of OVN, mitigating potential issues that could arise from using a continuously updated branch.

Highlights

  • OVN Version Pinning: The OVN build process has been updated to explicitly check out a specific commit hash (70df1aba7dd36c38905dc643ca709d8e85e541a7) instead of cloning a specific branch.
  • Dockerfile Update: The Dockerfile.base now reflects this change, ensuring that the OVN source code used for building is consistently from a known, stable point.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the OVN version to a specific commit hash by modifying the Dockerfile. The current implementation uses a full git clone, which is inefficient for Docker builds. My review provides a suggestion to optimize the cloning process to improve build performance and reduce network usage.

Comment thread dist/images/Dockerfile.base Outdated
Comment on lines +97 to +98
RUN cd /usr/src/ && git clone https://github.com/ovn-org/ovn.git && \
cd ovn && git checkout 70df1aba7dd36c38905dc643ca709d8e85e541a7 && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For build efficiency, it's better to avoid a full git clone. Cloning the entire repository history can significantly slow down the image build process and increase network usage. While a full clone is one way to get a specific commit that isn't at a branch tip, there are more efficient methods.

A better approach is to use a partial clone with --filter=blob:none. This avoids downloading file contents (blobs) until they are needed at checkout, making the initial clone much faster. This feature is supported by the version of Git available in the ubuntu:24.04 base image.

RUN cd /usr/src/ && git clone --filter=blob:none https://github.com/ovn-org/ovn.git && \
    cd ovn && git checkout 70df1aba7dd36c38905dc643ca709d8e85e541a7 && \

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 4, 2025

Pull Request Test Coverage Report for Build 19070786628

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.541%

Totals Coverage Status
Change from base Build 19054987369: 0.0%
Covered Lines: 10940
Relevant Lines: 50787

💛 - Coveralls

@changluyi changluyi force-pushed the revert_ovn_commit_fix_migrate_error branch 2 times, most recently from cc566df to fe35e45 Compare November 5, 2025 06:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 5, 2025
@changluyi changluyi force-pushed the revert_ovn_commit_fix_migrate_error branch from fe35e45 to 04936f8 Compare November 5, 2025 06:55
Signed-off-by: clyi <clyi@alauda.io>
@changluyi changluyi force-pushed the revert_ovn_commit_fix_migrate_error branch from 6d76ad7 to 8297d72 Compare November 5, 2025 07:50
@changluyi changluyi closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants