Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions MAINTAINERS
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
| Maintainer | GitHub Username | Company |
| -------------- | ---------------------------------------------- | ------------- |
| Mengxin Liu | [@oilbeater](https://github.com/oilbeater) | Alauda Inc |
| Zujian Zhang | [@zhangzujian](https://github.com/zhangzujian) | Alauda Inc |
| Hongzhen Ma | [@hzma](https://github.com/hongzhen-ma) | Alauda Inc |
| Riming Fan | [@fanriming](https://github.com/fanriming) | China Telecom |
| Bingbing Zhang | [@bobz965](https://github.com/bobz965) | Individual |
| YuDong Wang | [@wangyd1988](https://github.com/wangyd1988) | Inspur |
| Maintainer | GitHub Username | Company |
| -------------- | -------------------------------------------------- | ------------- |
| Mengxin Liu | [@oilbeater](https://github.com/oilbeater) | Alauda Inc |
| Zujian Zhang | [@zhangzujian](https://github.com/zhangzujian) | Alauda Inc |
| Hongzhen Ma | [@hzma](https://github.com/hongzhen-ma) | Alauda Inc |
| Riming Fan | [@fanriming](https://github.com/fanriming) | China Telecom |
| Bingbing Zhang | [@bobz965](https://github.com/bobz965) | Individual |
| YuDong Wang | [@wangyd1988](https://github.com/wangyd1988) | Inspur |
| SkalaNetworks | [@SkalaNetworks](https://github.com/SkalaNetworks) | SKALA SYSTEMS |
Comment on lines +1 to +9
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The markdown table formatting is misaligned, which affects the readability of the file in its raw text form. I suggest re-aligning all columns for consistency and better maintainability.

| Maintainer     | GitHub Username                                    | Company       |
|----------------|----------------------------------------------------|---------------|
| Mengxin Liu    | [@oilbeater](https://github.com/oilbeater)         | Alauda Inc    |
| Zujian Zhang   | [@zhangzujian](https://github.com/zhangzujian)     | Alauda Inc    |
| Hongzhen Ma    | [@hzma](https://github.com/hongzhen-ma)            | Alauda Inc    |
| Riming Fan     | [@fanriming](https://github.com/fanriming)           | China Telecom |
| Bingbing Zhang | [@bobz965](https://github.com/bobz965)               | Individual    |
| YuDong Wang    | [@wangyd1988](https://github.com/wangyd1988)         | Inspur        |
| SkalaNetworks  | [@SkalaNetworks](https://github.com/SkalaNetworks) | SKALA SYSTEMS |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

According to the project's GOVERNANCE.md, maintainers are expected to be individuals. The document states, 'maintainers are people who care about the Kube-OVN project'. The new entry for 'SkalaNetworks' appears to be a GitHub organization, not an individual, which would be inconsistent with the governance policy.

Furthermore, for consistency with other entries in this file, the 'Maintainer' column should contain the person's full name, while the 'GitHub Username' column contains their GitHub handle. The current entry uses 'SkalaNetworks' for both.

If 'SkalaNetworks' represents an individual, please update this line to use their full name in the 'Maintainer' column. If it is an organization, this may require a broader discussion and a potential update to GOVERNANCE.md before this change can be merged.