Skip to content

fix metallb e2e faile #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
changluyi merged 1 commit into from
Nov 4, 2025
Merged

fix metallb e2e faile #5856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/e2e/metallb/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/utils/ptr"

Check failure on line 19 in test/e2e/metallb/e2e_test.go

View workflow job for this annotation

GitHub Actions / Build kube-ovn 

File is not properly formatted (gofumpt)
clientset "k8s.io/client-go/kubernetes"
"k8s.io/klog/v2"
"k8s.io/kubernetes/test/e2e"
Expand Down Expand Up @@ -358,13 +359,15 @@
},
}
service := framework.MakeService(serviceName, corev1.ServiceTypeLoadBalancer, nil, podLabels, ports, "")
service.Spec.IPFamilyPolicy = ptr.To(corev1.IPFamilyPolicySingleStack)
service.Spec.ExternalTrafficPolicy = corev1.ServiceExternalTrafficPolicyTypeLocal
_ = serviceClient.CreateSync(service, func(s *corev1.Service) (bool, error) {
return len(s.Status.LoadBalancer.Ingress) != 0, nil
}, "first lb service ip is not empty")

ginkgo.By("Creating the second service for the same deployment")
service2 := framework.MakeService(serviceName2, corev1.ServiceTypeLoadBalancer, nil, podLabels, ports, "")
service2.Spec.IPFamilyPolicy = ptr.To(corev1.IPFamilyPolicySingleStack)
service2.Spec.ExternalTrafficPolicy = corev1.ServiceExternalTrafficPolicyTypeLocal
_ = serviceClient.CreateSync(service2, func(s *corev1.Service) (bool, error) {
return len(s.Status.LoadBalancer.Ingress) != 0, nil
Expand Down
Loading