Skip to content

just test#5872

Closed
changluyi wants to merge 1 commit intomasterfrom
revert_ovn_commit_fix_migrate_error
Closed

just test#5872
changluyi wants to merge 1 commit intomasterfrom
revert_ovn_commit_fix_migrate_error

Conversation

@changluyi
Copy link
Copy Markdown
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: clyi <clyi@alauda.io>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 6, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @changluyi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the Dockerfile.base to refine the process of cloning and managing the OVN (Open Virtual Network) repository during the image build. The changes ensure that the full OVN repository history is available and that a specific, consistent version of OVN is used by hard-resetting to a designated commit hash.

Highlights

  • OVN Repository Cloning: The --depth=1 option has been removed from the git clone command for the ovn-org/ovn repository. This change means the full history of the OVN repository will now be cloned instead of a shallow clone.
  • OVN Version Pinning: A git reset --hard command has been added immediately after cloning the OVN repository. This explicitly pins the repository to a specific commit hash (d6f67771b336f5e16ac3fa74258de96cbb748ff6), ensuring a consistent version is used for subsequent build steps.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Dockerfile.base to pin the OVN dependency to a specific commit. While pinning versions is good practice, the method used (cloning the full repository history) is inefficient and will increase Docker image size and build times. My review includes a suggestion for a more efficient method to fetch only the specific commit required, which maintains the benefit of version pinning while keeping the build process lean.

Comment on lines +97 to +98
RUN cd /usr/src/ && git clone -b branch-25.03 https://github.com/ovn-org/ovn.git && \
cd ovn && git reset --hard d6f67771b336f5e16ac3fa74258de96cbb748ff6 && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Cloning the full repository by removing --depth=1 is inefficient. It significantly increases the Docker image size and build time because it downloads the entire git history. A better approach for pinning to a specific commit is to initialize a repository and fetch only that single commit. This achieves the same goal much more efficiently.

RUN cd /usr/src/ && git init ovn && \
    cd ovn && git remote add origin https://github.com/ovn-org/ovn.git && git fetch --depth 1 origin d6f67771b336f5e16ac3fa74258de96cbb748ff6 && git reset --hard FETCH_HEAD && \

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19132450817

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.536%

Totals Coverage Status
Change from base Build 19131241215: 0.0%
Covered Lines: 10938
Relevant Lines: 50789

💛 - Coveralls

@changluyi changluyi closed this Nov 6, 2025
@oilbeater oilbeater deleted the revert_ovn_commit_fix_migrate_error branch February 24, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants