Skip to content

fix(vpcnatgateway): bgp speaker would crash if no ipv4 is available #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oilbeater merged 1 commit into from
Dec 16, 2025
Merged

fix(vpcnatgateway): bgp speaker would crash if no ipv4 is available #6059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/speaker/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,11 @@ func ParseFlags() (*Configuration, error) {
if config.RouterID == nil {
if podIPv4 != "" {
config.RouterID = net.ParseIP(podIPv4)
} else {
Comment thread
zbb88888 marked this conversation as resolved.
config.RouterID = net.ParseIP(podIPv6)
}

if config.RouterID == nil {
return nil, errors.New("no router id or POD_IPS")
// RouterID must be an IPv4. If no IPv4 exists on the speaker, fallback to 0.0.0.0 to avoid GoBGP crashing.
config.RouterID = net.ParseIP("0.0.0.0")
}
Comment thread
SkalaNetworks marked this conversation as resolved.
}

Expand Down
Loading