Skip to content

ci: fix loading vpc-nat-gateway image into kind cluster#6128

Merged
zhangzujian merged 1 commit intokubeovn:masterfrom
zhangzujian:cni-e2e
Jan 6, 2026
Merged

ci: fix loading vpc-nat-gateway image into kind cluster#6128
zhangzujian merged 1 commit intokubeovn:masterfrom
zhangzujian:cni-e2e

Conversation

@zhangzujian
Copy link
Copy Markdown
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @zhangzujian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a CI issue related to loading the vpc-nat-gateway image into a kind cluster by updating the versions of several core Kube-OVN component images. The changes ensure that the CI pipeline can correctly provision and utilize the necessary images, thereby improving the reliability of automated testing and deployments.

Highlights

  • Image Version Updates: Multiple component image tags have been updated to v1.16.0 to ensure compatibility and address potential issues.
  • DPDK Image Tag: The DPDK_IMAGE_TAG in charts/kube-ovn/values.yaml has been upgraded from v1.14.0-dpdk to v1.16.0-dpdk.
  • Kube-OVN Component Images: The kube-ovn-speaker image, vpc-nat-gateway image, and kube-ovn-webhook image have all been updated to v1.16.0.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build-x86-image.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various container image tags to v1.16.0 across Helm chart values and static YAML manifests. This brings consistency and fixes an issue with loading the vpc-nat-gateway image as mentioned in the title. The changes are correct and improve the consistency of image versions used. I've added one suggestion regarding the maintainability of the static YAMLs in the yamls/ directory to prevent version drift in the future.

containers:
- name: kube-ovn-speaker
image: "docker.io/kubeovn/kube-ovn:v1.15.0"
image: "docker.io/kubeovn/kube-ovn:v1.16.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating this version to v1.16.0 is correct for consistency, this change highlights a maintainability issue. Image versions are hardcoded across multiple static YAML files (speaker.yaml, webhook.yaml, etc.). This practice is error-prone and led to the version inconsistencies that this PR is fixing (e.g., some images were at v1.14.0 while others were at v1.15.0).

To improve maintainability, consider using a tool like Kustomize to manage these manifests. With Kustomize, you could define the image tags in a central kustomization.yaml file and have it patch all the manifests automatically. This would prevent version drift and simplify future updates.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20742383048

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.741%

Totals Coverage Status
Change from base Build 20741578819: 0.0%
Covered Lines: 12184
Relevant Lines: 53577

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review January 6, 2026 09:12
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 6, 2026
@zhangzujian zhangzujian merged commit 0c9250b into kubeovn:master Jan 6, 2026
73 of 75 checks passed
@zhangzujian zhangzujian deleted the cni-e2e branch January 6, 2026 09:12
zhangzujian added a commit that referenced this pull request Jan 6, 2026
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci need backport size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants