ci: fix loading vpc-nat-gateway image into kind cluster#6128
ci: fix loading vpc-nat-gateway image into kind cluster#6128zhangzujian merged 1 commit intokubeovn:masterfrom
Conversation
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Summary of ChangesHello @zhangzujian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a CI issue related to loading the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates various container image tags to v1.16.0 across Helm chart values and static YAML manifests. This brings consistency and fixes an issue with loading the vpc-nat-gateway image as mentioned in the title. The changes are correct and improve the consistency of image versions used. I've added one suggestion regarding the maintainability of the static YAMLs in the yamls/ directory to prevent version drift in the future.
| containers: | ||
| - name: kube-ovn-speaker | ||
| image: "docker.io/kubeovn/kube-ovn:v1.15.0" | ||
| image: "docker.io/kubeovn/kube-ovn:v1.16.0" |
There was a problem hiding this comment.
While updating this version to v1.16.0 is correct for consistency, this change highlights a maintainability issue. Image versions are hardcoded across multiple static YAML files (speaker.yaml, webhook.yaml, etc.). This practice is error-prone and led to the version inconsistencies that this PR is fixing (e.g., some images were at v1.14.0 while others were at v1.15.0).
To improve maintainability, consider using a tool like Kustomize to manage these manifests. With Kustomize, you could define the image tags in a central kustomization.yaml file and have it patch all the manifests automatically. This would prevent version drift and simplify future updates.
Pull Request Test Coverage Report for Build 20742383048Details
💛 - Coveralls |
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)