feat(chart): make daemonset update strategy configurable in values.yaml

[oujonny]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features

make ovsOvn daemonset update strategy configurable in values.yaml.

The chart sets it to onDelete if the DaemonSet exists on a cluster, but this Helm functionality is not working within ArgoCD, see: argoproj/argo-cd#5202. Therefore, we would like to have it configurable to manually override the value later, also to onDelete. To not break the existing logic, I suggest keeping the default value of the new variable "RollingUpdate"

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Summary of Changes

Hello @oujonny, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Kube-OVN Helm chart by making the update strategy for the ovsOvn DaemonSet configurable. This change provides greater flexibility for users to manage how OVS/OVN components are updated across their Kubernetes cluster, moving from a fixed 'RollingUpdate' strategy to one that can be defined in the chart's values.yaml.

Highlights

• Configurable DaemonSet Update Strategy: Introduced a new configuration option in values.yaml to allow users to specify the update strategy for the ovsOvn DaemonSet.
• Dynamic Update Strategy Application: The _helpers.tpl template now dynamically applies the ovsOvn.updateStrategy value from values.yaml, replacing the previously hardcoded 'RollingUpdate' strategy.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new value in values.yaml to make the ovs-ovn DaemonSet's update strategy configurable. The change correctly updates the helper template to use this new value. However, the implementation is incomplete as it doesn't apply the same configurable strategy to the ovs-ovn-dpdk DaemonSet, and it can produce a sub-optimal Kubernetes manifest when the strategy is set to OnDelete. I've left a detailed comment with suggestions for improvement.

[coveralls]

Pull Request Test Coverage Report for Build 20810153012

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 22.734%

---

Totals
Change from base Build 20774129238:	0.0%
Covered Lines:	12184
Relevant Lines:	53593

---

💛 - Coveralls

[oujonny]

@oilbeater I would like to see this PR later backported to v1.14.x and 1.15.x charts, can we make this happen somehow?

[oilbeater]

@oujonny I will cherry-pick it back.