feat(chart): introduce extraEnv variable for all components

[oujonny]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features

introduce extraEnv variable for all components

We are currently hitting this issue #5393 (on ubuntu 22.04.5). Therefore, having this option would make our lives way easier :)
Also, here a back port to v1.14.x and v1.15.x would be required so we can profit from it.

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Summary of Changes

Hello @oujonny, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the configurability of the Kube-OVN Helm chart by introducing a new extraEnv parameter for all deployed components. This allows operators to define and inject custom environment variables into any Kube-OVN pod through the Helm values.yaml file, providing a flexible and standardized mechanism for advanced customization and operational adjustments without altering the core chart templates.

Highlights

• Centralized Environment Variable Injection: Introduced a new extraEnv variable in the Helm chart for all Kube-OVN components, allowing users to easily inject custom environment variables into their respective pods.
• Enhanced Configurability: This feature provides greater flexibility for advanced configurations and debugging by enabling direct manipulation of pod environment variables via Helm values.
• Broad Component Coverage: The extraEnv functionality has been consistently applied across all major Kube-OVN components, including agent, central, controller, IC, monitor, OVS/OVN, pinger, speaker, and webhook.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new extraEnv values.yaml variable to allow for the injection of extra environment variables into all components of the Helm chart. While this is a useful feature, the implementation has a critical flaw in all the template files. The use of nindent combined with the indentation of the toYaml call will result in incorrectly indented YAML, causing Helm to fail when rendering the chart. I have provided comments with code suggestions in each affected file to correct the indentation, which should resolve the issue.

[coveralls]

Pull Request Test Coverage Report for Build 20830893921

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.003%) to 22.731%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/ovs/ovn-nb-logical_router_route.go	2	74.6%

Totals
Change from base Build 20811271438:	-0.003%
Covered Lines:	12182
Relevant Lines:	53593

---

💛 - Coveralls

[oilbeater]

Backport to release-1.15 and release-1.14