-
Notifications
You must be signed in to change notification settings - Fork 522
some left crd add description #6147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ spec: | |
| type: object | ||
| properties: | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name for the DNS service. This field is immutable after creation. | ||
| subnet: | ||
|
|
@@ -542,6 +543,7 @@ spec: | |
| type: array | ||
| description: External subnets accessible through the NAT gateway | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name for the NAT gateway. This field is immutable after creation. | ||
|
Comment on lines
+546
to
548
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a duplicate type: string
description: VPC name for the NAT gateway. This field is immutable after creation. |
||
| selector: | ||
|
|
@@ -1103,6 +1105,7 @@ spec: | |
| - rule: "self == oldSelf" | ||
| message: "This field is immutable." | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name for the egress gateway. This field is immutable after creation. | ||
|
Comment on lines
+1108
to
1110
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a duplicate type: string
description: VPC name for the egress gateway. This field is immutable after creation. |
||
| internalSubnet: | ||
|
|
@@ -1634,6 +1637,7 @@ spec: | |
| type: string | ||
| description: Redo operation status | ||
| protocol: | ||
| description: Network protocol (IPv4, IPv6, or Dual). Immutable after creation. | ||
| type: string | ||
| description: Protocol type of the DNAT rule | ||
|
Comment on lines
+1640
to
1642
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a duplicate type: string
description: Protocol type of the DNAT rule |
||
| internalIp: | ||
|
|
@@ -1679,6 +1683,7 @@ spec: | |
| type: string | ||
| description: External port number | ||
| protocol: | ||
| description: Network protocol (IPv4, IPv6, or Dual). Immutable after creation. | ||
| type: string | ||
| description: Protocol type (TCP or UDP) | ||
|
Comment on lines
+1686
to
1688
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| internalIp: | ||
|
|
@@ -1967,6 +1972,7 @@ spec: | |
| type: string | ||
| description: IPv6 address mapped to the FIP | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name where the FIP is configured | ||
|
Comment on lines
+1975
to
1977
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| conditions: | ||
|
|
@@ -2009,6 +2015,7 @@ spec: | |
| type: string | ||
| description: IP resource name | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name. This field is immutable after creation. | ||
|
Comment on lines
+2018
to
2020
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| v4Ip: | ||
|
|
@@ -2080,6 +2087,7 @@ spec: | |
| type: string | ||
| description: IPv6 CIDR configured in the SNAT rule | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name where the SNAT rule is configured | ||
|
Comment on lines
+2090
to
2092
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a duplicate type: string
description: VPC name where the SNAT rule is configured |
||
| conditions: | ||
|
|
@@ -2119,6 +2127,7 @@ spec: | |
| type: string | ||
| description: IP resource name | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name. This field is immutable after creation. | ||
|
Comment on lines
+2130
to
2132
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| v4IpCidr: | ||
|
|
@@ -2205,6 +2214,7 @@ spec: | |
| type: string | ||
| description: IPv6 address configured in the DNAT rule | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name where the DNAT rule is configured | ||
|
Comment on lines
+2217
to
2219
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a duplicate type: string
description: VPC name where the DNAT rule is configured |
||
| externalPort: | ||
|
|
@@ -2214,6 +2224,7 @@ spec: | |
| type: string | ||
| description: Internal port configured in the DNAT rule | ||
| protocol: | ||
| description: Network protocol (IPv4, IPv6, or Dual). Immutable after creation. | ||
| type: string | ||
| description: Protocol type configured in the DNAT rule | ||
|
Comment on lines
+2227
to
2229
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a duplicate type: string
description: Protocol type configured in the DNAT rule |
||
| ipName: | ||
|
|
@@ -2262,9 +2273,11 @@ spec: | |
| type: string | ||
| description: Internal port number to forward traffic to | ||
| protocol: | ||
| description: Network protocol (IPv4, IPv6, or Dual). Immutable after creation. | ||
| type: string | ||
| description: Protocol type (TCP or UDP) | ||
|
Comment on lines
+2276
to
2278
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| description: VPC name. This field is immutable after creation. | ||
|
Comment on lines
+2280
to
2282
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| v4Ip: | ||
|
|
@@ -2324,10 +2337,12 @@ spec: | |
| type: array | ||
| description: List of namespaces that can use this VPC | ||
| extraExternalSubnets: | ||
| description: Extra external subnets for provider-network VLAN. Immutable after creation. | ||
| items: | ||
| type: string | ||
| type: array | ||
| staticRoutes: | ||
| description: Static routes for the VPC. | ||
| items: | ||
| properties: | ||
| policy: | ||
|
|
@@ -2345,6 +2360,7 @@ spec: | |
| type: object | ||
| type: array | ||
| policyRoutes: | ||
| description: Policy routes for the VPC. | ||
| items: | ||
| properties: | ||
| priority: | ||
|
|
@@ -2361,6 +2377,7 @@ spec: | |
| type: object | ||
| type: array | ||
| vpcPeerings: | ||
| description: VPC peering configurations. | ||
| items: | ||
| properties: | ||
| remoteVpc: | ||
|
|
@@ -2455,10 +2472,12 @@ spec: | |
| type: string | ||
| type: array | ||
| extraExternalSubnets: | ||
| description: Extra external subnets for provider-network VLAN. Immutable after creation. | ||
| items: | ||
| type: string | ||
| type: array | ||
| vpcPeerings: | ||
| description: VPC peering configurations. | ||
| items: | ||
| type: string | ||
| type: array | ||
|
|
@@ -2849,22 +2868,26 @@ spec: | |
| type: object | ||
| properties: | ||
| vpc: | ||
| description: VPC name for the subnet. Immutable after creation. | ||
| type: string | ||
| default: | ||
| type: boolean | ||
| protocol: | ||
| description: Network protocol (IPv4, IPv6, or Dual). Immutable after creation. | ||
| type: string | ||
| enum: | ||
| - IPv4 | ||
| - IPv6 | ||
| - Dual | ||
| cidrBlock: | ||
| description: CIDR block for the subnet. Immutable after creation. | ||
| type: string | ||
| namespaces: | ||
| type: array | ||
| items: | ||
| type: string | ||
| gateway: | ||
| description: Gateway IP address for the subnet. | ||
| type: string | ||
| provider: | ||
| type: string | ||
|
|
@@ -2907,6 +2930,7 @@ spec: | |
| items: | ||
| type: string | ||
| natOutgoing: | ||
| description: Enable NAT for outgoing traffic. | ||
| type: boolean | ||
| externalEgressGateway: | ||
| type: string | ||
|
|
@@ -2931,6 +2955,7 @@ spec: | |
| private: | ||
| type: boolean | ||
| vlan: | ||
| description: VLAN ID for the subnet. Immutable after creation. | ||
| type: string | ||
| logicalGateway: | ||
| type: boolean | ||
|
|
@@ -2939,6 +2964,7 @@ spec: | |
| disableInterConnection: | ||
| type: boolean | ||
| enableDHCP: | ||
| description: Enable DHCP for the subnet. | ||
| type: boolean | ||
| dhcpV4Options: | ||
| type: string | ||
|
|
@@ -2949,8 +2975,10 @@ spec: | |
| ipv6RAConfigs: | ||
| type: string | ||
| allowEWTraffic: | ||
| description: Allow east-west traffic between pods. | ||
| type: boolean | ||
| acls: | ||
| description: Access control lists for the subnet. | ||
| type: array | ||
| items: | ||
| type: object | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a duplicate
descriptionkey for thevpcfield, which is invalid in an OpenAPI schema. Please consolidate the descriptions into a single one. The existing description seems more appropriate for theVpcDnsresource.