Skip to content

refactor: consolidate pod deletion logic for stateful and VM pods#6183

Merged
oilbeater merged 1 commit intomasterfrom
chore/remove-duplicate
Jan 20, 2026
Merged

refactor: consolidate pod deletion logic for stateful and VM pods#6183
oilbeater merged 1 commit intomasterfrom
chore/remove-duplicate

Conversation

@oilbeater
Copy link
Copy Markdown
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • chore

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 19, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @oilbeater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the pod deletion handling within the controller by consolidating the conditional logic for delaying pod deletions. Previously, separate checks existed for StatefulSet and VM pods; these have now been combined into a single, more concise expression. This change improves code maintainability and clarity without altering the functional behavior of pod deletion delays.

Highlights

  • Consolidated Pod Deletion Logic: The logic responsible for delaying the deletion of both StatefulSet pods and VM pods has been unified into a single conditional check, enhancing code readability and reducing redundancy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the refactor label Jan 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the pod deletion logic in enqueueUpdatePod to consolidate handling for stateful and VM pods. The change removes duplicated code by combining two separate if blocks into a single conditional check, improving code readability and maintainability. The logic remains correct, and this is a good improvement.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21130946794

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 22.884%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/pod.go 0 3 0.0%
Totals Coverage Status
Change from base Build 21127640406: 0.002%
Covered Lines: 12285
Relevant Lines: 53683

💛 - Coveralls

@oilbeater oilbeater merged commit 3328759 into master Jan 20, 2026
75 of 77 checks passed
@oilbeater oilbeater deleted the chore/remove-duplicate branch January 20, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants