test: run ginkgo via go tool

[zhangzujian]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features
• Bug fixes
• Docs
• Tests

Which issue(s) this PR fixes

Avoid ginkgo version mismatch:

Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.27.3
  Mismatched package versions found:
    2.27.5 used by multus

[gemini-code-assist]

Summary of Changes

Hello @zhangzujian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue of Ginkgo version mismatches during testing by centralizing and standardizing the way the Ginkgo CLI is executed. By leveraging go tool and Go modules, it ensures that the correct version of Ginkgo is always used, thereby improving the reliability and consistency of both unit and end-to-end tests. The changes also refactor test command definitions in Makefiles for better maintainability.

Highlights

• Standardized Ginkgo Invocation: Introduced a GINKGO Makefile variable to consistently invoke Ginkgo using go tool, ensuring version consistency across test runs.
• Go Module Integration for Ginkgo: Added the Ginkgo CLI to go.mod's tool directive, allowing Go modules to manage its version and prevent mismatches between the CLI and imported packages.
• Refactored E2E Test Commands: Consolidated common Ginkgo build and run commands in makefiles/e2e.mk into new, reusable variables (GINKGO_E2E_BUILD, GINKGO_E2E_RUN, GINKGO_E2E_RUN_PARALLEL) for cleaner and more maintainable test targets.
• Updated Test Targets: Modified all relevant e2e and unit test Makefile targets to utilize the new standardized Ginkgo invocation and command variables.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/build-x86-image.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a great improvement by running ginkgo via go tool to prevent version mismatches. The changes are well-implemented across the Makefiles. I appreciate the refactoring of the Makefiles, such as consolidating multiple ginkgo build commands into a single one in makefiles/e2e.mk, which improves efficiency and readability. Using prerequisites in the iptables-vpc-nat-gw-conformance-e2e target and replacing a shell if with $(RM) are also nice touches that make the build scripts more idiomatic and robust. Overall, this is a solid contribution that enhances the project's build system.

[coveralls]

Pull Request Test Coverage Report for Build 21237898140

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 22.889%

---

Totals
Change from base Build 21233717843:	0.0%
Covered Lines:	12303
Relevant Lines:	53751

---

💛 - Coveralls