Skip to content

fix: host no kube-ovn-speaker log#6196

Merged
zbb88888 merged 1 commit intokubeovn:masterfrom
zbb88888:fix-host-no-bgp-speaker-log
Jan 23, 2026
Merged

fix: host no kube-ovn-speaker log#6196
zbb88888 merged 1 commit intokubeovn:masterfrom
zbb88888:fix-host-no-bgp-speaker-log

Conversation

@zbb88888
Copy link
Copy Markdown
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #(issue-number)

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 22, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @zbb88888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the kube-ovn-speaker component was not generating logs, hindering the ability to diagnose and troubleshoot issues. By introducing specific logging arguments, the change ensures that critical operational data from the speaker is consistently recorded, significantly improving the observability and debuggability of the Kube-OVN network.

Highlights

  • Kube-OVN Speaker Logging: Explicitly configured the kube-ovn-speaker component to output logs to a dedicated file (/var/log/kube-ovn/kube-ovn-speaker.log) and also to stderr. This ensures that speaker logs are captured for debugging and operational monitoring.
  • Log File Management: Set a maximum size of 200MB for the kube-ovn-speaker log file, preventing it from consuming excessive disk space.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the bug Something isn't working label Jan 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where kube-ovn-speaker was not producing logs on the host. It achieves this by adding several command-line arguments to the kube-ovn-speaker container in both the Helm chart (charts/kube-ovn-v2/templates/speaker/speaker.yaml) and the static manifest (yamls/speaker.yaml). The added arguments correctly configure klog to write logs to a file that is mounted from the host.

My review focuses on improving the maintainability and configurability of these changes. I've suggested making the hardcoded log file size configurable in the Helm chart and adding a guiding comment in the static manifest. These changes will make the configuration more flexible and user-friendly.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21243324836

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.889%

Totals Coverage Status
Change from base Build 21238354955: 0.0%
Covered Lines: 12303
Relevant Lines: 53751

💛 - Coveralls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2026
Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>
@zbb88888 zbb88888 force-pushed the fix-host-no-bgp-speaker-log branch from f1eb3a6 to eeac0ae Compare January 23, 2026 13:28
@zbb88888 zbb88888 merged commit 9636d72 into kubeovn:master Jan 23, 2026
9 checks passed
@zbb88888 zbb88888 deleted the fix-host-no-bgp-speaker-log branch January 23, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants