controller: fix vpc egress gateway not working for targets within the…#6218
Merged
zhangzujian merged 1 commit intokubeovn:masterfrom Jan 28, 2026
Merged
controller: fix vpc egress gateway not working for targets within the…#6218zhangzujian merged 1 commit intokubeovn:masterfrom
zhangzujian merged 1 commit intokubeovn:masterfrom
Conversation
… internal subnet's cidr Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Pull Request Test Coverage Report for Build 21397805276Details
💛 - Coveralls |
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the issue where the VPC egress gateway was not correctly handling targets within the internal subnet's CIDR. The changes correctly modify the logic to include these internal subnet CIDRs in the source sets for routing, which aligns with the PR's stated goal. The introduction of ipv4Src and ipv6Src to collect all relevant source CIDRs and their subsequent use in OVN route reconciliation is a logical and necessary step for this fix.
dosubot
bot
added
size:S
oilbeater
approved these changes
Jan 27, 2026
zhangzujian
added a commit
that referenced
this pull request
Jan 28, 2026
… internal subnet's cidr (#6218) Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian
added a commit
that referenced
this pull request
Jan 28, 2026
… internal subnet's cidr (#6218) Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zbb88888
pushed a commit
to qiniu/kube-ovn
that referenced
this pull request
Jan 29, 2026
… internal subnet's cidr (kubeovn#6218) Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… internal subnet's cidr
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)