chore(deps): update dependency golangci-lint to v2.10.1 (master)

.github/workflows/build-x86-image.yaml

@@ -24,7 +24,7 @@ env:
   # renovate: datasource=github-releases depName=kind packageName=kubernetes-sigs/kind
   KIND_VERSION: v0.31.0
   # renovate: datasource=github-releases depName=golangci-lint packageName=golangci/golangci-lint
-  GOLANGCI_LINT_VERSION: v2.8.0
+  GOLANGCI_LINT_VERSION: v2.10.1
   # renovate: datasource=github-releases depName=helm packageName=helm/helm
   HELM_VERSION: v4.1.1
   # renovate: datasource=github-releases depName=submariner packageName=submariner-io/submariner

.golangci.yml

@@ -40,6 +40,9 @@ linters:
       - linters:
           - revive
         text: avoid meaningless package names
+      - linters:
+          - revive
+        text: avoid package names that conflict with Go standard library package names
       # Exclude gosec from running on tests files.
       - linters:
           - gosec

pkg/apis/kubeovn/v1/vpc-nat-gateway.go

@@ -65,7 +65,7 @@ type VpcBgpSpeaker struct {
 	Neighbors             []string        `json:"neighbors"`
 	HoldTime              metav1.Duration `json:"holdTime"`
 	RouterID              string          `json:"routerId"`
-	Password              string          `json:"password"`
+	Password              string          `json:"password"` // #nosec G117
 	EnableGracefulRestart bool            `json:"enableGracefulRestart"`
 	ExtraArgs             []string        `json:"extraArgs"`
 }

pkg/controller/subnet.go

@@ -1468,16 +1468,16 @@ func (c *Controller) reconcileEcmpCentralizedSubnetRouteInDefaultVpc(subnet *kub
 	v4CIDR, v6CIDR := util.SplitStringIP(subnet.Spec.CIDRBlock)
 	cidrs := [2]string{v4CIDR, v6CIDR}
 	for i, cidr := range cidrs {
-		if len(nodeIPs[i]) == 0 || cidr == "" {
+		if len(nodeIPs[i]) == 0 || cidr == "" { // #nosec G602
 			continue
 		}
 		klog.Infof("delete old distributed policy route for subnet %s", subnet.Name)
 		if err := c.deletePolicyRouteByGatewayType(subnet, kubeovnv1.GWDistributedType, false); err != nil {
 			klog.Errorf("failed to delete policy route for overlay subnet %s, %v", subnet.Name, err)
 			return err
 		}
-		klog.Infof("subnet %s configure ecmp policy route, nexthops %v", subnet.Name, nodeIPs[i])
-		if err := c.updatePolicyRouteForCentralizedSubnet(subnet.Name, cidr, nodeIPs[i], nameIPMaps[i]); err != nil {
+		klog.Infof("subnet %s configure ecmp policy route, nexthops %v", subnet.Name, nodeIPs[i])                     // #nosec G602
+		if err := c.updatePolicyRouteForCentralizedSubnet(subnet.Name, cidr, nodeIPs[i], nameIPMaps[i]); err != nil { // #nosec G602
 			klog.Errorf("failed to add ecmp policy route for centralized subnet %s: %v", subnet.Name, err)
 			return err
 		}

pkg/ovn_ic_controller/ovn_ic_controller.go

@@ -486,10 +486,10 @@ func genHostAddress(host, port string) (hostAddress string) {
 		var builder strings.Builder
 		i := 0
 		for i < len(hostList)-1 {
-			builder.WriteString(fmt.Sprintf("tcp:[%s]:%s,", hostList[i], port))
+			fmt.Fprintf(&builder, "tcp:[%s]:%s,", hostList[i], port)
 			i++
 		}
-		builder.WriteString(fmt.Sprintf("tcp:[%s]:%s", hostList[i], port))
+		fmt.Fprintf(&builder, "tcp:[%s]:%s", hostList[i], port)
 		hostAddress = builder.String()
 	}
 	return hostAddress

pkg/ovn_leader_checker/ovn.go

@@ -245,7 +245,7 @@ func stealLock() {
 		args = slices.Insert(args, 0, ovs.CmdSSLArgs()...)
 	}
 
-	output, err := exec.Command("ovsdb-client", args...).CombinedOutput() // #nosec G204
+	output, err := exec.Command("ovsdb-client", args...).CombinedOutput() // #nosec G204 G702
 	if err != nil {
 		klog.Errorf("stealLock err %v", err)
 		return
@@ -267,7 +267,7 @@ func checkNorthdSvcExist(cfg *Configuration, namespace, svcName string) bool {
 
 func checkNorthdEpAvailable(ip string) bool {
 	address := util.JoinHostPort(ip, util.NBRaftPort)
-	conn, err := net.DialTimeout("tcp", address, northdDialTimeout)
+	conn, err := net.DialTimeout("tcp", address, northdDialTimeout) // #nosec G704
 	if err != nil {
 		klog.Errorf("failed to connect to northd leader %s, err: %v", ip, err)
 		failCount++
@@ -529,8 +529,7 @@ func updateTS() error {
 				fmt.Sprintf(`external_ids:subnet="%s"`, subnet),
 				fmt.Sprintf(`external_ids:vendor="%s"`, util.CniTypeName),
 			)
-			// #nosec G204
-			cmd = exec.Command("ovn-ic-nbctl", args...)
+			cmd = exec.Command("ovn-ic-nbctl", args...) // #nosec G204 G702
 			output, err := cmd.CombinedOutput()
 			if err != nil {
 				return fmt.Errorf("output: %s, err: %w", output, err)

pkg/ovs/util.go

@@ -164,7 +164,7 @@ func formatDHCPOptions(options map[string]string) string {
 		if k == "dns_server" {
 			v = strings.ReplaceAll(v, ",", ";")
 		}
-		sb.WriteString(fmt.Sprintf("%s=%s", k, v))
+		fmt.Fprintf(&sb, "%s=%s", k, v)
 	}
 	return sb.String()
 }

pkg/tproxy/tproxy_tcp_linux.go

@@ -220,7 +220,7 @@ func dialTCP(device string, laddr, raddr *net.TCPAddr, dontAssumeRemote, isnonbl
 		return nil, &net.OpError{Op: "dial", Err: fmt.Errorf("socket connect: %w", err)}
 	}
 
-	fdFile := os.NewFile(uintptr(fileDescriptor), "net-tcp-dial-"+raddr.String())
+	fdFile := os.NewFile(uintptr(fileDescriptor), "net-tcp-dial-"+raddr.String()) // #nosec G115
 	defer func() {
 		if err := fdFile.Close(); err != nil {
 			klog.Errorf("fdFile %v Close err: %v", fdFile, err)

test/e2e/iptables-eip-qos/e2e_test.go

@@ -1034,32 +1034,32 @@ type bandwidthValidationResult struct {
 func formatBandwidthSummary(result bandwidthValidationResult, testType, direction string) string {
 	var sb strings.Builder
 	sb.WriteString("\n╔═══════════════════════════════════════════════════════════════════════════════╗\n")
-	sb.WriteString(fmt.Sprintf("║  QoS Bandwidth Test Summary - %s (%s)\n", testType, direction))
+	fmt.Fprintf(&sb, "║  QoS Bandwidth Test Summary - %s (%s)\n", testType, direction)
 	sb.WriteString("╠═══════════════════════════════════════════════════════════════════════════════╣\n")
-	sb.WriteString(fmt.Sprintf("║  QoS Limit:         %.2f Mbps\n", result.LimitMbps))
+	fmt.Fprintf(&sb, "║  QoS Limit:         %.2f Mbps\n", result.LimitMbps)
 
 	if result.MaxExpected > 0 {
-		sb.WriteString(fmt.Sprintf("║  Expected Range:    %.2f ~ %.2f Mbps (%.0f%% ~ %.0f%% of limit)\n",
+		fmt.Fprintf(&sb, "║  Expected Range:    %.2f ~ %.2f Mbps (%.0f%% ~ %.0f%% of limit)\n",
 			result.MinExpected, result.MaxExpected,
-			bandwidthToleranceLow*100, bandwidthToleranceHigh*100))
+			bandwidthToleranceLow*100, bandwidthToleranceHigh*100)
 	} else {
-		sb.WriteString(fmt.Sprintf("║  Expected:          > %.2f Mbps (QoS disabled, should exceed %.0f%% of limit)\n",
-			result.MinExpected, bandwidthToleranceHigh*100))
+		fmt.Fprintf(&sb, "║  Expected:          > %.2f Mbps (QoS disabled, should exceed %.0f%% of limit)\n",
+			result.MinExpected, bandwidthToleranceHigh*100)
 	}
 
 	sb.WriteString("║  Measured Values:   ")
 	for i, bw := range result.MeasuredMbps {
 		if i > 0 {
 			sb.WriteString(", ")
 		}
-		sb.WriteString(fmt.Sprintf("%.2f", bw))
+		fmt.Fprintf(&sb, "%.2f", bw)
 	}
 	sb.WriteString(" Mbps\n")
 
 	if result.Passed {
-		sb.WriteString(fmt.Sprintf("║  Best Match:        %.2f Mbps ✓ PASS\n", result.BestMatch))
+		fmt.Fprintf(&sb, "║  Best Match:        %.2f Mbps ✓ PASS\n", result.BestMatch)
 	} else {
-		sb.WriteString(fmt.Sprintf("║  Best Match:        %.2f Mbps ✗ FAIL\n", result.BestMatch))
+		fmt.Fprintf(&sb, "║  Best Match:        %.2f Mbps ✗ FAIL\n", result.BestMatch)
 	}
 
 	sb.WriteString("╚═══════════════════════════════════════════════════════════════════════════════╝\n")