feat: check for pod restarts after installation

[oujonny]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features

This PR improves the previously introduced chart testing for the kube-ovn-v2 helm chart. It features now a proper ct.yaml config file and performs additional checks after the installation to validate if pods are not crashing-looping.

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[coveralls]

Pull Request Test Coverage Report for Build 22306573215

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 825 unchanged lines in 12 files lost coverage.
• Overall coverage increased (+0.05%) to 23.057%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/ovn_leader_checker/ovn.go	2	0.0%
pkg/ovs/ovn-nb-bfd.go	2	61.61%
pkg/controller/vpc_lb.go	13	6.06%
pkg/metrics/dynamic_cert_key.go	29	4.24%
pkg/ovs/ovn-nb-logical_router_policy.go	31	80.61%
pkg/controller/ip.go	33	6.13%
pkg/controller/service_lb.go	50	0.0%
pkg/daemon/tproxy_linux.go	55	0.0%
pkg/controller/vpc_dns.go	65	0.0%
pkg/controller/init.go	105	0.0%

Totals
Change from base Build 22175163829:	0.05%
Covered Lines:	12533
Relevant Lines:	54357

---

💛 - Coveralls

[oujonny]

@SkalaNetworks, I improved the chart testing here and added the extra validation with the pod restarts check.
Here is an example of an successfull run: https://github.com/kubeovn/kube-ovn/actions/runs/22182595012/job/64147553679

The current run is failing, as I added files the chart dir (ct.yaml and .helmignore), therefore it requires a chart bump, but I would say that's not needed here particularly.

[SkalaNetworks]

#6308

As highlited in this PR, can we disable the chart bump check?

 --check-version-increment              Activates a check for chart version increments (default true)

[oujonny]

Hey
Yes aggree, for this particular chart make sense to disable this check. I implemented that via the ct.yaml config file.
Addtionalliy I revered the version bump introduced in #6184 (back to v1.16.0) for now.

[oujonny]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request significantly enhances the robustness of Helm chart testing for kube-ovn-v2 by integrating a chart-testing configuration file and introducing critical post-installation validations. The changes ensure greater stability by checking for pod restarts and streamline the testing process by customizing chart-testing behavior.

Highlights

• Enhanced Chart Testing: Improved the chart testing for the kube-ovn-v2 Helm chart by introducing a dedicated ct.yaml configuration file.
• Pod Restart Validation: Implemented additional post-installation checks to validate that pods are not entering a crashing-loop state after the Helm chart is deployed.
• Chart-Testing Configuration: Configured chart-testing to disable maintainer validation and version increment checks, addressing issues encountered during CI runs.
• Chart Version Reversion: Reverted the kube-ovn-v2 chart version in Chart.yaml from v1.16.1 back to v1.16.0.
• Helm Ignore Update: Added .ct.yaml to the .helmignore file to prevent it from being packaged with the Helm chart.

Changelog

• charts/kube-ovn-v2/.helmignore
  • Added .ct.yaml to the ignore list for Helm packaging.
• charts/kube-ovn-v2/Chart.yaml
  • Reverted the chart version from v1.16.1 to v1.16.0.
• charts/kube-ovn-v2/ct.yaml
  • Added a new chart-testing configuration file, disabling maintainer validation and version increment checks, and specifying namespace, release label, and skip clean-up options.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/helm-testing.yaml

Activity

• A bot comment indicated an inability to generate a summary due to unsupported file types.
• Coveralls reported on pull request test coverage, noting a warning about an inaccurate report due to an outdated base commit and an overall coverage increase of 0.05%.
• oujonny (author) commented on improving chart testing and adding pod restart checks, providing a successful run example and noting that the current run was failing due to added files requiring a chart bump, which they suggested was not needed.
• SkalaNetworks inquired about disabling the chart bump check.
• oujonny confirmed disabling the check-version-increment via the ct.yaml config file and mentioned reverting the version bump in Chart.yaml back to v1.16.0.
• oujonny requested a Gemini summary.

[SkalaNetworks]

@oujonny Question: do we need to check the "ct list-changed" ?

This CI/CD workflow should trigger when the Helm chart is changed, so why do we check again if it changes using "ct"?

Some steps run all the time (for example, the kind cluster). Only the lint runs if "ct list-changed" returned something, the rest runs all the time.

[oujonny]

@SkalaNetworks, I just copied that from the example GitHub action. It has its roots in the fact that the ct is built to support multiple charts in the same repo, I would say.

As we run this only against the v2 chart, I removed it.

[SkalaNetworks]

/lgtm