ci: upload kubectl-ko-log when check-restarts step fails#6321
Merged
ci: upload kubectl-ko-log when check-restarts step fails#6321
Conversation
Add log collection and upload steps after each "Check kube ovn pod restarts" step in the CI workflow. Previously, logs were only uploaded when e2e tests or installation failed, but not when the pod restart check itself failed. This makes it easier to diagnose issues when pods restart unexpectedly. Each check-restarts step now has an `id: check-restarts` so the subsequent log upload steps can conditionally trigger on its failure. Artifact names use `-restarts-ko-log` suffix to avoid conflicts with existing e2e failure log artifacts. Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
dosubot
bot
added
size:L
Pull Request Test Coverage Report for Build 22297646190Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id: check-restartsto all 26 "Check kube ovn pod restarts" steps in the CI workflow-restarts-ko-logartifact name suffix to avoid conflicts with existing e2e failure log artifactsMotivation
Previously,
kubectl-ko-logwas only uploaded when e2e tests or installation failed. If the pod restart check failed independently (e.g., e2e passed but unexpected pod restarts were detected), no logs were available for debugging. This change ensures logs are always collected when restart checks fail.Test plan
id: check-restarts🤖 Generated with Claude Code