fix(ovn): update patches for compatibility with upstream OVN branch-25.03#6331
fix(ovn): update patches for compatibility with upstream OVN branch-25.03#6331
Conversation
…5.03 Update three OVN patches to be compatible with recent upstream changes in branch-25.03 that introduced the `bool acl_ct_translation` parameter across lflow management functions. - 78cade01: add kube_ovn_hint parameter alongside acl_ct_translation - e7d3ba53: adjust insertion point after new if (!acl_ct_translation) block - e889d469: update line offsets for upstream code changes Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @oilbeater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates existing OVN patches to maintain compatibility with recent changes in the upstream OVN Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pull Request Test Coverage Report for Build 22360495409Details
💛 - Coveralls |
There was a problem hiding this comment.
Code Review
The pull request updates three OVN patches to ensure compatibility with recent upstream changes in branch-25.03. The primary changes involve introducing the bool acl_ct_translation parameter and a kube_ovn_hint parameter across various lflow management functions and macros. This includes modifications to function signatures, struct members, and macro definitions in lflow-mgr.c and lflow-mgr.h. Additionally, the patch adjusts the insertion point for node-local DNS conntrack skip logic in build_ls_stateful_rec_pre_acls() within northd.c and updates line offsets and index hashes to align with upstream code changes. The changes appear to be well-aligned with the stated goal of maintaining compatibility and introducing new functionality as described.
…5.03 (#6331) Update three OVN patches to be compatible with recent upstream changes in branch-25.03 that introduced the `bool acl_ct_translation` parameter across lflow management functions. - 78cade01: add kube_ovn_hint parameter alongside acl_ct_translation - e7d3ba53: adjust insertion point after new if (!acl_ct_translation) block - e889d469: update line offsets for upstream code changes Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit 820341d)
Summary
branch-25.03that introduced thebool acl_ct_translationparameter across lflow management functions78cade01: addkube_ovn_hintparameter alongside new upstreamacl_ct_translationin all lflow-mgr function signatures and macrose7d3ba53: adjust insertion point for node-local DNS conntrack skip after newif (!acl_ct_translation)block inbuild_ls_stateful_rec_pre_acls()e889d469: update line offsets and index hashes for upstream code changesTest plan
branch-25.03HEAD (f8c8b837)🤖 Generated with Claude Code