fix(e2e): fix checkPolicy logic bug and improve underlay test diagnostics

[oilbeater]

Summary

• Fix checkPolicy() logic bug: when expectPolicyExist=false, the original code returned true as soon as the first line did not contain the policy string, without scanning remaining lines. Now it correctly scans all lines before comparing against the expectation.
• Increase checkPolicy() timeout from 10s to 30s, consistent with other wait functions (waitSubnetStatusUpdate, waitSubnetU2OStatus).
• Add meaningful condDesc to waitSubnetStatusUpdate(), waitSubnetU2OStatus(), and checkPolicy() so timeout failures produce actionable error messages instead of empty strings like timed out while waiting for the condition to be met: .
• Replace ginkgo.By() with framework.Logf() inside polling loops in waitSubnetU2OStatus() to reduce noisy test output.

Test plan

• Verify the "should support underlay to overlay subnet interconnection" e2e test passes
• Verify checkPolicy() correctly detects both policy presence and absence
• Confirm timeout error messages now include descriptive condition text

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello @oilbeater, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability and diagnostic capabilities of end-to-end tests for Kube-OVN's underlay-to-overlay subnet interconnection. It addresses a critical logic flaw in the checkPolicy() function, standardizes wait timeouts, and significantly improves the clarity of error messages during test failures, while also reducing unnecessary log output.

Highlights

• checkPolicy() logic fix: Corrected a bug in checkPolicy() where it prematurely returned true when expectPolicyExist=false, ensuring all policy lines are scanned before comparison.
• Timeout adjustments: Increased the timeout for checkPolicy() and waitSubnetU2OStatus() from 10s/3s to 30s for consistency and robustness in e2e tests.
• Improved diagnostic messages: Added meaningful condition descriptions (condDesc) to waitSubnetStatusUpdate(), waitSubnetU2OStatus(), and checkPolicy() to provide actionable error messages on timeout.
• Reduced log verbosity: Replaced ginkgo.By() with framework.Logf() within polling loops in waitSubnetU2OStatus() to minimize noisy test output.

Changelog

• test/e2e/kube-ovn/underlay/underlay.go
  • Added a descriptive condition message to waitSubnetStatusUpdate to improve timeout diagnostics.
  • Increased the timeout duration for waitSubnetU2OStatus from 3 seconds to 30 seconds, replaced ginkgo.By calls with framework.Logf for cleaner logging, and added a descriptive condition message.
  • Fixed a logical error in checkPolicy's policy existence checking, extended its timeout from 10 seconds to 30 seconds, and included a descriptive condition message for better error reporting.

Activity

• The pull request was generated using Claude Code.
• A test plan was provided, including verification of the "should support underlay to overlay subnet interconnection" e2e test, checkPolicy() correctness, and improved timeout error messages.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a logic bug in the checkPolicy function and significantly improves the diagnostics and stability of the underlay e2e tests. The fix in checkPolicy is correct and ensures proper behavior when checking for policy absence. Increasing timeouts to 30s for wait functions is a good step towards reducing test flakiness. The addition of descriptive messages for wait conditions and the cleanup of logging within polling loops are excellent improvements for maintainability and debugging. Overall, these are solid enhancements to the test suite.

I am having trouble creating individual review comments. Click here to see my feedback.

test/e2e/kube-ovn/underlay/underlay.go (94-95)

Removing this redundant log statement is a good cleanup. However, similar redundant framework.Logf calls still exist within the if enableU2O block (lines 79-80 and 85-86 in the file). These logs are also triggered when the wait condition is met. For consistency and to further reduce log noise, consider removing those logging statements as well.