Skip to content

fix(ci): redesign log upload steps in build-x86-image workflow#6361

Merged
oilbeater merged 1 commit intomasterfrom
fix/redesign-log-upload-steps
Feb 27, 2026
Merged

fix(ci): redesign log upload steps in build-x86-image workflow#6361
oilbeater merged 1 commit intomasterfrom
fix/redesign-log-upload-steps

Conversation

@oilbeater
Copy link
Copy Markdown
Collaborator

Summary

  • Merge duplicate ko-log upload steps (e2e-failure + restarts-failure) into one unified pair per job, eliminating 230 lines of duplication
  • Fix artifact name conflicts: all ko-log artifacts now include full matrix variables to prevent collisions across matrix combinations
  • Expand events/audit-log/ko-log collection conditions to also trigger on install step failures
  • Fix 5 existing bugs: wrong step IDs in ipsec/ipsec-cert-mgr/connectivity jobs and missing matrix vars in cilium-chaining artifact name

Test plan

  • Verify all E2E jobs still collect logs correctly on failure
  • Confirm no artifact name collisions across matrix combinations
  • Check that install failures now trigger log collection
  • Validate YAML syntax is correct (verified locally with yaml.safe_load)

🤖 Generated with Claude Code

Consolidate duplicate ko-log upload steps, fix artifact name conflicts,
and ensure log collection covers install failures.

Changes:
- Merge two ko-log pairs (e2e-failure + restarts-failure) into one
  unified pair per job, reducing 230 lines of duplication
- Fix artifact name conflicts: all ko-log artifacts now include full
  matrix variables (e.g., ip-family, mode, ssl) to prevent collisions
- Expand events/audit-log/ko-log collection conditions to also trigger
  on install step failures, not just e2e failures
- Replace simple single-cluster ko-log with multi-cluster collection
  for IC conformance job

Bug fixes:
- Fix wrong step ID in kube-ovn-ipsec-e2e events collection
  (steps.ovn-ipsec-e2e -> steps.kube-ovn-ipsec-e2e)
- Fix wrong step ID in kube-ovn-ipsec-cert-mgr-e2e events collection
  (steps.ovn-ipsec-cert-mgr-e2e -> steps.kube-ovn-ipsec-cert-mgr-e2e)
- Fix typo in kube-ovn-ipsec-cert-mgr-e2e audit-log upload condition
  (steps.kube-ovn-ipse-cert-mgrc-e2e -> steps.kube-ovn-ipsec-cert-mgr-e2e)
- Fix wrong step ID in kube-ovn-connectivity-test upload condition
  (steps.kube-ovn-connectivity-e2e -> steps.e2e)
- Fix missing matrix variables in cilium-chaining-e2e first ko-log
  artifact name

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. ci github_actions Pull requests that update GitHub Actions code labels Feb 27, 2026
@oilbeater oilbeater merged commit e43e1d9 into master Feb 27, 2026
76 checks passed
@oilbeater oilbeater deleted the fix/redesign-log-upload-steps branch February 27, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci github_actions Pull requests that update GitHub Actions code size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant