Skip to content

Support KubeVirt CCM Deployment #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

moadqassem
Copy link
Member

What this PR does / why we need it:
This PR supports the deployment and the configurations for the KubeVirt CCM.
Which issue(s) this PR fixes:

Fixes #
/kind feature
What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support KubeVirt CCM Deployment

Documentation:

None

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 21, 2025
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from moadqassem. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2025
Signed-off-by: moadqassem <[email protected]>
@moadqassem moadqassem force-pushed the support-kubevirt-ccm branch from db80241 to 9dcecab Compare May 21, 2025 18:26
@moadqassem moadqassem requested a review from kron4eg May 21, 2025 18:28
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs some more:

  • generate and update the Secret with CCM config (based on the provided kubeone manifest)
  • enable the addon if kubevirt is a selected cloud provider
  • preferably write a Kustomization file to generate ccm YAML automatically and add any customizations if necessary or at least have a README.md that describes "what, where and when" WRT to YAML manifest obtaining

@xmudrii xmudrii removed the kind/feature Categorizes issue or PR as related to a new feature. label May 23, 2025
@kubermatic-bot kubermatic-bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 23, 2025
@xmudrii xmudrii added release-blocker kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-blocker labels May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants