Skip to content

Cherry Pick #4712,#4671 To Release 26#4737

Open
laureanobrs wants to merge 2 commits intokubernetes-client:release-26from
laureanobrs:laureanobrs-cherry-pick-4712
Open

Cherry Pick #4712,#4671 To Release 26#4737
laureanobrs wants to merge 2 commits intokubernetes-client:release-26from
laureanobrs:laureanobrs-cherry-pick-4712

Conversation

@laureanobrs
Copy link
Copy Markdown

@laureanobrs laureanobrs commented May 5, 2026 •
edited
Loading

@brendandburns @laureanobrs
Fix ModelMapper.processJarPackage breaking on paths containing '+'
bdcf33d 
Agent-Logs-Url: https://github.com/kubernetes-client/java/sessions/251a25c1-d66c-4929-94c7-9fb3323acc89

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
(cherry picked from commit 23bb7ee)
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laureanobrs
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 5, 2026

Welcome @laureanobrs!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2026
@laureanobrs laureanobrs marked this pull request as ready for review May 5, 2026 02:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2026
@laureanobrs laureanobrs mentioned this pull request May 5, 2026
Closed
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented May 5, 2026

@copilot please add the changes from #4713 to this PR

@laureanobrs
Copy link
Copy Markdown
Author

laureanobrs commented May 5, 2026

@brendandburns Can Copilot make changes to a PR from a fork? If not, I can manually add those changes.

@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented May 6, 2026

@laureanobrs I was trying to save you effort, but if you wanted to cherrypick that PR that'd be great.

@laureanobrs
Copy link
Copy Markdown
Author

laureanobrs commented May 6, 2026 •
edited
Loading

@brendandburns Could it be that the PR we want to cherry-pick is #4671 instead of #4713?

If I understand correctly, #4713 is for the master-java8 branch, and cherry-picking it here would imply a downgrade of the GHA used in the workflows.

Once we confirm it, I’ll do the cherry-pick.

@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented May 7, 2026

@laureanobrs oops, sorry yes, you are correct.

@brendandburns @laureanobrs
Pin GitHub Actions to SHA hashes for security compliance
e684c54 
Agent-Logs-Url: https://github.com/kubernetes-client/java/sessions/36bdac51-f2b4-44e4-b468-2ddceecc3d28

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
(cherry picked from commit 8e0441d)
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2026
@laureanobrs laureanobrs changed the title Cherry Pick #4712 To Release 26 Cherry Pick #4712,#4671 To Release 26 May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laureanobrs @k8s-ci-robot @brendandburns