-
Notifications
You must be signed in to change notification settings - Fork 295
Add --enable-snapshot-compression flag to control snapshot compression #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add a new driver parameter to control whether compression is performed when creating volume snapshots. This addresses the feature request to skip gzip compression when storing already-compressed data, which can significantly speed up snapshot creation and restoration. Changes: - Add EnableSnapshotCompression field to DriverOptions and Driver structs - Add --enable-snapshot-compression flag (default: true for backward compatibility) - Update CreateSnapshot to respect compression setting - Update copyFromSnapshot to auto-detect archive format for backward compatibility - Update archiveName() to return .tar or .tar.gz based on compression setting - Update Helm chart values and templates - Update documentation - Add unit tests for compression toggle functionality Co-authored-by: andyzhangx <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds
--enable-snapshot-compressiondriver parameter to control whether gzip compression is applied when creating volume snapshots. Users storing already-compressed data can set this tofalseto skip redundant compression, significantly speeding up snapshot creation and restoration.Changes:
EnableSnapshotCompressiontoDriverOptionsandDriverstructs--enable-snapshot-compressionCLI flag (default:true)CreateSnapshotto use.taror.tar.gzbased on settingcopyFromSnapshotto auto-detect archive format for backward compatibilitycontroller.enableSnapshotCompressionUsage:
# Disable compression for pre-compressed data --enable-snapshot-compression=falseWhich issue(s) this PR fixes:
Fixes #891
Special notes for your reviewer:
truepreserves existing behavior.tar.gzfirst, then.tar) ensuring backward compatibility with existing compressed snapshotsTarPack/TarUnpack) and external tar command paths updatedDoes this PR introduce a user-facing change?:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.