fix: correct storageclass annotations and node dnsPolicy in latest chart#1103
Merged
andyzhangx merged 1 commit intokubernetes-csi:release-4.13from Apr 19, 2026
Merged
Conversation
Contributor
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/XS
andyzhangx
removed
the
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
needs-rebase
Cherry-pick of PR kubernetes-csi#1102 for release-4.13 branch. - Move annotations key inside with block to avoid rendering null annotations - Fix node DaemonSet dnsPolicy to use node.dnsPolicy instead of controller.dnsPolicy
andyzhangx
force-pushed
the
fix-latest-chart-issues-4.13
branch
from
b902b9f to
d40b8e4
Compare
k8s-ci-robot
removed
the
needs-rebase
andyzhangx
merged commit 64071c5
into
kubernetes-csi:release-4.13
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Cherry-pick of #1102 for release-4.13 branch.
annotations:key was rendered outside thewithblock, causingannotations: nullwhen.Values.storageClass.annotationsis unsetdnsPolicywas using.Values.controller.dnsPolicyinstead of.Values.node.dnsPolicyChanges:
storageclass.yaml: moveannotations:inside thewithblockcsi-nfs-node.yaml: use.Values.node.dnsPolicy