[release-4.13] fix: use syscall.Chmod to correctly handle setgid/setuid/sticky bits in mountPermissions#1110
Merged
k8s-ci-robot merged 4 commits intokubernetes-csi:release-4.13from Apr 20, 2026
Conversation
…in mountPermissions os.Chmod with os.FileMode does not correctly map Unix setgid (02000), setuid (04000), or sticky (01000) bits because Go os.FileMode uses different bit positions for these flags. For example, mountPermissions of 02770 (setgid + rwxrwx) would only apply 0770 via os.Chmod, silently dropping the setgid bit. Switch to syscall.Chmod which takes raw Unix mode bits directly. Also use chmodIfPermissionMismatch in CreateVolume for consistency, and use 0777 for MkdirAll in NodePublishVolume since the subsequent chmodIfPermissionMismatch handles the actual permission setting. Ref 940
…n mask, add special-bit tests - Split syscall.Chmod into platform-specific files (chmod_unix.go, chmod_windows.go) with build tags to avoid breaking Windows builds - Fix permission comparison mask in chmodIfPermissionMismatch to include setuid/setgid/sticky bits, not just os.ModePerm (0777) - Add fileModeToUnixMode helper to correctly convert raw Unix mode values to Go's os.FileMode representation - Add unit tests for special bits (02770, 01777, 04755) in chmod_unix_test.go
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1106
/assign andyzhangx