-
Notifications
You must be signed in to change notification settings - Fork 247
Add documentation for VolumeAttributesClass #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/release-note-none |
book/src/volume-attributes.md
Outdated
To take advantage of `VolumeAttibutesClass` feature: | ||
* The CSI driver must implement the `MODIFY_VOLUME` capability. | ||
* The Kubernetes administrator must create the `VolumeAttributesClass` with the relevant `parameters` for the `driverName` | ||
* The user can then patch the `PersistentVolume` under `spec.volumeAttributesClassName` to select or update the settings he needs for the volume. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch PersistentVolumeClaim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch ! Thx.
/assign @sunnylovestiramisu |
book/src/volume-attributes.md
Outdated
|
||
Status | Min K8s Version | Max K8s Version | external-provisioner Version | ||
-------|-----------------|-----------------|----------------------------- | ||
Alpha | 1.29 | - | 5.0.2+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a min external-provisioner version that is supporting the feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunnylovestiramisu to make sure I get this right, you want 1st version that introduced volume attributes ; right ?
So in alpha it is v4.0.0 & for beta v5.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated now
book/src/volume-attributes.md
Outdated
## Status | ||
|
||
Status | Min K8s Version | Max K8s Version | external-provisioner Version | ||
-------|-----------------|-----------------|----------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should list both external-provisioner Version and external-resizer Version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
External-resizer version added
book/src/SUMMARY.md
Outdated
@@ -46,6 +46,7 @@ | |||
- [Volume Mode Conversion](prevent-volume-mode-conversion.md) | |||
- [Cross-Namespace Data Sources](cross-namespace-data-sources.md) | |||
- [Changed Block Tracking](changed-block-tracking.md) | |||
- [Volume Attributes Class](volume-attributes.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is not volume-attributes-class.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file renamed as suggested
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coulof, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.