Add aggregated RBAC for VolumeSnapshots

[RoniKishner]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds aggregated ClusterRoles (snapshot-admin, snapshot-edit, snapshot-view) that automatically extend the built-in Kubernetes admin, edit, and view roles with permissions for VolumeSnapshot resources.

Non-admin users can GET/list PVCs but cannot access VolumeSnapshots, even when they have admin, edit, or view roles in a namespace. This is because PVC permissions are built into Kubernetes core, while VolumeSnapshot (as a CRD) requires explicit aggregated RBAC rules

Non-admin users can GET/list PVCs but cannot access VolumeSnapshots, even when they have admin, edit, or view roles in a namespace. This is because PVC permissions are built into Kubernetes core, while VolumeSnapshot (as a CRD) requires explicit aggregated RBAC rules. Since VolumeSnapshots are created from PVCs and used to restore PVCs, users who can manage PVCs should have equivalent access to VolumeSnapshots.

Does this PR introduce a user-facing change?:

Users with admin, edit, or view roles in a namespace can now access VolumeSnapshots without requiring cluster-admin privileges.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: RoniKishner / name: Roni Kishner (f831313)

[k8s-ci-robot]

Welcome @RoniKishner!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @RoniKishner. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RoniKishner
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment