-
Notifications
You must be signed in to change notification settings - Fork 609
feat: add support for more workload types #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for more workload types #1052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another non-standard workload rule missing for workloads you would see from the following query:
group by (owner_kind) (kube_pod_owner{owner_kind!="ReplicaSet", owner_kind!="DaemonSet", owner_kind!="StatefulSet", owner_kind!="Job", owner_kind!="Node", owner_kind!=""})
That should capture workload types that are directly controlled via CRDs like StrimziPodSet
for example.
No join is required for this additional rule as the pods are created directly rather than via ReplicaSets.
Co-authored-by: Stephen Lang <[email protected]>
Co-authored-by: Stephen Lang <[email protected]>
Co-authored-by: Stephen Lang <[email protected]>
Update
namespace_workload_pod:kube_pod_owner:relabel
recording rule to support more workload types, which now include (but not limited to):replicaset
NEW (also supports other replicaset types e.g.Rollout
)deployment
UPDATED - fixedreplicaset
appearing asdeployment
with emptyworkload
label, those will now appear as the newreplicaset
type insteaddaemonset
statefulset
job
UPDATED - now includes support forPod
job typeCronJob
NEW (also supports other job types e.g.ScaledJob
)barepod
NEW - a pod without a controllerstaticpod
NEW - a pod controlled by a static file manifest on diskStrimziPodSet
Unit tests for all of the above test cases have been added.
An example deployment is shown to be healthy below, which proves the individual rules are mutually exclusive (otherwise duplicate series would be rejected):