chore: refactor resources/node#1174
Draft
sleepyfoodie wants to merge 1 commit intokubernetes-monitoring:masterfrom
Draft
chore: refactor resources/node#1174sleepyfoodie wants to merge 1 commit intokubernetes-monitoring:masterfrom
sleepyfoodie wants to merge 1 commit intokubernetes-monitoring:masterfrom
Conversation
skl
requested changes
Feb 4, 2026
Collaborator
skl
left a comment
skl
left a comment
There was a problem hiding this comment.
Please ensure this is tested, thanks!
| datasource: datasource, | ||
| cluster: clusterVar, | ||
| node: | ||
| common.queryVar( |
Collaborator
There was a problem hiding this comment.
make dev
RUNTIME ERROR: Field does not exist: queryVar
dashboards/resources/variables/node.libsonnet:11:9-24 object <anonymous>
dashboards/resources/node.libsonnet:343:77-91 thunk from <thunk from <object <anonymous>>>
Array element 2
Field "list"
Field "templating"
Field "k8s-resources-node.json"
During manifestation
make: *** [dashboards_out/.dashboards-generated] Error 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to test how the otel queries for node scale, this will need to be refactored too for the k8s otel mixin.