Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

feat(controlplane): gateway resource cleanup#443

Merged
k8s-ci-robot merged 1 commit intokubernetes-retired:mainfrom
hargut:fix/gateway-finalizers-cleanup
Sep 2, 2025
Merged

feat(controlplane): gateway resource cleanup#443
k8s-ci-robot merged 1 commit intokubernetes-retired:mainfrom
hargut:fix/gateway-finalizers-cleanup

Conversation

@hargut
Copy link
Copy Markdown
Contributor

@hargut hargut commented Aug 29, 2025

use a finalizer to clean up created resources

fixes #440

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2025
use a finalizer to clean up created resources

Signed-off-by: Harald Gutmann <harald@gutmann.one>
@shaneutt shaneutt added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 2, 2025
Copy link
Copy Markdown
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hargut, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 95ed451 into kubernetes-retired:main Sep 2, 2025
4 checks passed
@hargut hargut deleted the fix/gateway-finalizers-cleanup branch September 2, 2025 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway resources cleanup on deletion not present

3 participants