Skip to content

Conversation

@AlbeeSo
Copy link
Member

@AlbeeSo AlbeeSo commented Jan 12, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 12, 2026
@k8s-ci-robot k8s-ci-robot requested review from huww98 and iltyty January 12, 2026 08:27
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlbeeSo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2026
@huww98
Copy link
Contributor

huww98 commented Jan 12, 2026

If I understand this correctly, the reader may race with the old dir cleanup process, trying to read the already deleted files. I think it is OK, ossfs should retry when facing this. Let's remove this case to avoid flake.

/lgtm
/kind flake

Example flake: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_alibaba-cloud-csi-driver/1604/pull-alibaba-cloud-csi-driver-verify-unit/2010622176385830912

=== RUN   TestRotateTokenFiles_SymlinkAtomicUpdate/verify_consistency_during_concurrent_reads
    ossfs_secret_test.go:1282: 
        	Error Trace:	/home/prow/go/src/github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/interceptors/ossfs_secret_test.go:1282
        	Error:      	Not equal: 
        	            	expected: "aksecret1"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-aksecret1
        	            	+
        	Test:       	TestRotateTokenFiles_SymlinkAtomicUpdate/verify_consistency_during_concurrent_reads
        	Messages:   	AccessKeySecret should match old version
    ossfs_secret_test.go:1284: 
        	Error Trace:	/home/prow/go/src/github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/interceptors/ossfs_secret_test.go:1284
        	Error:      	Not equal: 
        	            	expected: "exp1"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-exp1
        	            	+
        	Test:       	TestRotateTokenFiles_SymlinkAtomicUpdate/verify_consistency_during_concurrent_reads
        	Messages:   	Expiration should match old version

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Jan 12, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 1e8e801 into kubernetes-sigs:master Jan 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants