Adding Helm Parameter CI Tests#2868
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
Code Coverage DiffThis PR does not change the code coverage |
mdzraf
changed the title
mdzraf
force-pushed
the
AddHelmParamCITests
branch
from
b3ad7d8 to
b074ab6
Compare
|
/test pull-aws-ebs-csi-driver-e2e-single-az |
|
/test pull-aws-ebs-csi-driver-verify |
mdzraf
force-pushed
the
AddHelmParamCITests
branch
from
b074ab6 to
3334fde
Compare
|
/test pull-aws-ebs-csi-driver-e2e-single-az |
| param_set_legacy-compat() { | ||
| GINKGO_FOCUS="\[param:(useOldCSIDriver|legacyXFS)\]" | ||
| HELM_EXTRA_FLAGS="--set=useOldCSIDriver=true,node.legacyXFS=true" | ||
| } | ||
|
|
||
| param_set_selinux() { | ||
| GINKGO_FOCUS="\[param:selinux\]" | ||
| HELM_EXTRA_FLAGS="--set=node.selinux=true" | ||
| } |
There was a problem hiding this comment.
These are not in the PARAMETERS_ALL test for now, I will see if they need a separate cluster or not.
|
/hold Have to reverse single-az makefile target before merging |
k8s-ci-robot
added
the
do-not-merge/hold
mdzraf
force-pushed
the
AddHelmParamCITests
branch
from
3334fde to
976d61c
Compare
|
/test pull-aws-ebs-csi-driver-e2e-single-az |
mdzraf
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Noticed some tests are being skipped, looking into it. |
| # standard - Behavioral params (tagging, metrics, logging, storage classes, etc.) | ||
| # other - Volume modification, volume attach limit, and metadata labeler | ||
| # debug - debugLogs=true overrides individual logLevel settings | ||
| # infra - Infrastructure/deployment params (resources, security, strategy, etc.) |
There was a problem hiding this comment.
Why is storage classes in standard and not in infra it is a cluster resource
There was a problem hiding this comment.
Also why are we dividing these into categories at all ? If we end up running them all anyways
mdzraf
force-pushed
the
AddHelmParamCITests
branch
2 times, most recently
from
21ccf1e to
8437c58
Compare
mdzraf
force-pushed
the
AddHelmParamCITests
branch
from
8437c58 to
68a45c5
Compare
3 participants
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds individual tests for the various helm parameters that can be configured when deploying the driver.
How was this change tested?
Tested manually by running:
Also ran in CI under the existing single-az testing grid. It will have it's own test grid after this merges but put under single-az for reviewers to see results and JUnit outputs.
Does this PR introduce a user-facing change?