-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrefixListsIDs field to IngressClassParams #3860
Add PrefixListsIDs field to IngressClassParams #3860
Conversation
|
Hi @gdlx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @gdlx! |
a21e4c7
to
2a8f458
Compare
/ok-to-test |
2a8f458
to
8a2e4e3
Compare
/retest |
8a2e4e3
to
23f271b
Compare
Hi @kishorj @M00nF1sh @shraddhabang ! |
23f271b
to
b253f20
Compare
Hello, I apologize that we had neglected to review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for the contribution.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gdlx, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks a lot @zac-nixon! |
Issue
Fixes #3859
Description
Just adds the PrefixListIDs param to IngressClassParams resource.
I hesitated with calling it SecurityGroupPrefixListIDs to match the annotation name but I went for the shorter option. Please tell me if I should switch to the longer one.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯