[feat] allow multiple targetgroupbindings to reference same tg arn if using multicluster mode #4021
+144
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
zac-nixon
force-pushed
the
znixon/mc-same-cluster
branch
from
6d1a33c to
d118858
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
the
needs-rebase
zac-nixon
force-pushed
the
znixon/mc-same-cluster
branch
from
d118858 to
d00b175
Compare
k8s-ci-robot
removed
the
needs-rebase
wweiwei-li
reviewed
Jan 28, 2025
| @@ -72,6 +73,9 @@ func (v *targetGroupBindingValidator) ValidateCreate(ctx context.Context, obj ru | |||
| if err := v.checkAssumeRoleConfig(tgb); err != nil { | |||
| return err | |||
| } | |||
| if err := v.checkExistingTargetGroups(tgb); err != nil { | |||
There was a problem hiding this comment.
checkExistingTargetGroups is being called twice, which is not need ?
There was a problem hiding this comment.
bad rebase on my part.
…multi cluster mode
zac-nixon
force-pushed
the
znixon/mc-same-cluster
branch
from
d00b175 to
92ae3dc
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
wweiwei-li
approved these changes
Jan 28, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
Users would like to utilize the same Target Group ARN for multiple TargetGroupBindings. Previously, before Multicluster support, this was not possible as the reconcile logic would be unaware of other entities registering targets into the configured Target Group. Now, using Multicluster TargetGroupBindings, the reconcile logic is able to only operate on targets in the Target Group that belong to the specified TargetGroupBinding.
We can relax the validation logic to allow users to specify duplicate Target Group ARNs if they also specify the Multicluster flag on each binding.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯