Skip to content

Conversation

@zac-nixon
Copy link
Collaborator

Issue

#4497

Description

Per the issue, they were trying to use kubernetes.io/h2c to set the protocol version to HTTP2 on the constructed target group. Digging a bit, I had started working on supporting Service AppProtocol but left it half done (and the half that was done was incorrect :/)

This change adds support for the kubernetes.io/h2c AppProtocol (converting to HTTP2 on the TG). It also..

  1. Adds guard rails so we don't attempt to set protocol version on listeners that don't support it. Credit to @starlightromero for noticing this edgecase.
  2. Removed some incorrect AppProtocol validations, I was incorrectly using http and grpc as AppProtocol values.

In the future, I'd like to set up LBC specific protocol versions as per the AppProtocol spec: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol but in the meantime, I'd like to get minimal support working while removing the obviously incorrect AppProtocol references in our code.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants