refactor app protocol, add support for app protocols that kubernetes + elb supports #4500
+194
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4497
Description
Per the issue, they were trying to use
kubernetes.io/h2cto set the protocol version to HTTP2 on the constructed target group. Digging a bit, I had started working on supporting Service AppProtocol but left it half done (and the half that was done was incorrect :/)This change adds support for the
kubernetes.io/h2cAppProtocol (converting to HTTP2 on the TG). It also..httpandgrpcas AppProtocol values.In the future, I'd like to set up LBC specific protocol versions as per the AppProtocol spec: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol but in the meantime, I'd like to get minimal support working while removing the obviously incorrect AppProtocol references in our code.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯