Skip to content

[WIP] fix: optimizations and fstype fix from intree to csi#3501

Open
hasethuraman wants to merge 1 commit intokubernetes-sigs:masterfrom
hasethuraman:hari/optimization-and-fstype-fix
Open

[WIP] fix: optimizations and fstype fix from intree to csi#3501
hasethuraman wants to merge 1 commit intokubernetes-sigs:masterfrom
hasethuraman:hari/optimization-and-fstype-fix

Conversation

@hasethuraman
Copy link
Contributor

@hasethuraman hasethuraman commented Feb 4, 2026

What type of PR is this?

fstype was not inherited from intree pv to csi
also optimized by caching the jsons to avoid repeated kubectl queries in the interest of maintenance window to reduce application downtime

/kind bug

What this PR does / why we need it:

Without this PR, the csi pv is failing to mount due to filesystem mismatch
And without this, in a scale volume, the script overhead is high before trigger the migration

Which issue(s) this PR fixes:
Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Feb 4, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hasethuraman
Once this PR has been reviewed and has the lgtm label, please assign landreasyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @hasethuraman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2026
@hasethuraman hasethuraman force-pushed the hari/optimization-and-fstype-fix branch from eaf2329 to 7a02fd8 Compare February 5, 2026 15:52
@hasethuraman hasethuraman marked this pull request as ready for review February 5, 2026 15:52
@k8s-ci-robot k8s-ci-robot requested a review from cvvz February 5, 2026 15:52
@hasethuraman hasethuraman marked this pull request as draft February 5, 2026 15:54
@hasethuraman hasethuraman marked this pull request as ready for review February 5, 2026 16:03
@hasethuraman
Copy link
Contributor Author

For some reason I dont see the edit icon to remove [WIP] from PR title. Could someone help to remove it? Thanks

@landreasyan @andyzhangx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants