WIP - CLB #9770
WIP - CLB #9770
Conversation
Co-authored-by: David Kowalski <[email protected]>
…provider-azure into clb-backendpool
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
k8s-ci-robot
added
do-not-merge/needs-kind
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @georgeedward2000. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
github-actions
bot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
cncf-cla: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: georgeedward2000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
…onfig struct - Removed PRE_MERGE_CHECKLIST.md and REVIEW_SUMMARY.md as they are no longer needed. - Updated ServiceOperationState to use ServiceConfig instead of IsInbound boolean. - Refactored AddService, DeleteService, and related methods to utilize ServiceConfig for better configuration management. - Enhanced validation logic in ServiceConfig to ensure service UID is not empty. - Adjusted tests to accommodate changes in ServiceOperationState and ServiceConfig. - Improved metrics tracking to reflect changes in service configuration. - Cleaned up service updater logic to align with new configuration structure.
- Improved the logic for handling pod updates in `azure_servicegateway_pods.go` to better manage IP initialization, label changes, and pod validity states. - Added comprehensive unit tests for `podInformerAddPod`, `podInformerRemovePod`, and `podInformerUpdateFunc` to ensure correct behavior under various scenarios, including edge cases. - Introduced helper functions for building resource names in `resource_helpers.go` to streamline resource management. - Enhanced error handling and logging in `initialization.go` and `service_updater.go` to improve clarity during resource creation and deletion processes. - Updated the `DiffTracker` to ensure proper triggering of location updates and validation of network client initialization.
…ion states, and fully unregister services from ServiceGateway
…ization improvements - Added atomic counters and initialization tracking to the DiffTracker to manage in-flight updater triggers and check for initialization completion. - Updated LocationsUpdater and ServiceUpdater to decrement the in-flight trigger counter and check for initialization completion asynchronously. - Introduced filtering in service synchronization to only include services that are in the StateCreated state, preventing premature synchronization attempts. - Improved logging for service synchronization and equality checks between K8s and NRP resources for better observability. - Adjusted performance test parameters to reduce the number of services created in parallel, ensuring stability during tests.
2 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: