Skip to content

Conversation

@mboersma
Copy link
Contributor

@mboersma mboersma commented Jan 7, 2026

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Updates several Makefile targets so their make help messages are shown.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Before:

% make

Usage:
  make <target>

General
  help             Display this help.

Binaries
  all              Build binaries for the project.

Images
  build-ccm-image  Build controller-manager image.
  build-node-image-linux  Build node-manager image.
  build-node-image-windows  Build node-manager image for Windows.
  build-node-image-windows-hpc  Build node-manager image for Windows.
  build-ccm-e2e-test-image  Build e2e test image.
  push-ccm-image   Push controller-manager image.
  push-node-image-linux  Push node-manager image for Linux.
  release-ccm-e2e-test-image  Build and release e2e test image.
  hyperkube        Build hyperkube image.

All Arch or OS Version
  image            Build all images.
  push             Push all images.
  .PHONY           Push multi-arch controller-manager image
  push-multi-arch-controller-manager-image  Create and push a manifest list containing all the Linux ccm images.
  .PHONY           Push multi-arch node-manager image
  push-multi-arch-node-manager-image  Create and push a manifest list containing all the Windows and Linux images.
  .PHONY           Push node-manager image for os and archs.
  .PHONY           Push node-manager image for Linux.
  .PHONY           Push node-manager image for Windows.
  .PHONY           Push node-manager image for Windows.
  .PHONY           Build node-manager image for all OS and archs.
  .PHONY           Build node-manager image for Linux.
  .PHONY           Build node-manager image for Windows.

Tests
  test-unit        Run unit tests.
  test-check       Run all static checks.
  lint             Run golangci-lint against code.
  test-boilerplate  Run boilerplate test.
  test-helm        Validate helm charts
  verify-vendor-licenses  Verify vendor licenses
  update-helm      Update helm charts
  update-dependencies  Update dependencies and go modules.
  update-gofmt     Update go formats.
  update-mocks     Create or update mock clients.
  update-vendor-licenses  Update vendor licenses
  update           Update go formats, mocks and dependencies.
  test-e2e         Run k8s e2e tests.
  test-e2e-capz    Run k8s e2e tests with capz
  test-ccm-e2e     Run cloud provider e2e tests.
  clean            Cleanup local builds.

Release
  deploy           Build, push and deploy an aks-engine cluster.
  release-staging  Release the cloud provider images.

Deploy clusters with capz

Tools
  golangci-lint    Download golangci-lint locally if necessary.

After:

% make

Usage:
  make <target>

General
  help             Display this help.

Binaries
  all              Build binaries for the project.

Images
  build-ccm-image  Build controller-manager image.
  build-node-image-linux  Build node-manager image.
  build-node-image-windows  Build node-manager image for Windows.
  build-node-image-windows-hpc  Build node-manager image for Windows.
  build-ccm-e2e-test-image  Build e2e test image.
  push-ccm-image   Push controller-manager image.
  push-node-image-linux  Push node-manager image for Linux.
  release-ccm-e2e-test-image  Build and release e2e test image.
  hyperkube        Build hyperkube image.

All Arch or OS Version
  image            Build all images.
  push             Push all images.
  push-multi-arch-controller-manager-image  Push multi-arch controller-manager image
  push-multi-arch-node-manager-image  Push multi-arch node-manager image
  push-all-node-images  Push node-manager image for os and archs.
  push-all-node-images-linux  Push node-manager image for Linux.
  push-all-node-images-windows  Push node-manager image for Windows.
  push-all-node-images-windows-hpc  Push node-manager image for Windows.
  build-all-node-images  Build node-manager image for all OS and archs.
  build-all-node-images-linux  Build node-manager image for Linux.
  build-all-node-images-windows  Build node-manager image for Windows.
  build-all-ccm-images  Build all CCM images.
  push-all-ccm-images  Push all CCM images.
  manifest-node-manager-image-windows  Create and push Windows node-manager manifest.
  manifest-node-manager-image-windows-hpc  Create and push Windows HPC node-manager manifest.

Tests
  test-unit        Run unit tests.
  test-check       Run all static checks.
  lint             Run golangci-lint against code.
  test-boilerplate  Run boilerplate test.
  test-helm        Validate helm charts
  verify-vendor-licenses  Verify vendor licenses
  update-helm      Update helm charts
  update-dependencies  Update dependencies and go modules.
  update-gofmt     Update go formats.
  update-mocks     Create or update mock clients.
  update-vendor-licenses  Update vendor licenses
  update           Update go formats, mocks and dependencies.
  test-e2e         Run k8s e2e tests.
  test-e2e-capz    Run k8s e2e tests with capz
  ensure-azcli     Ensure az CLI is installed.
  test-ccm-e2e     Run cloud provider e2e tests.
  clean            Cleanup local builds.

Release
  deploy           Build, push and deploy an aks-engine cluster.
  cloud-build-prerequisites  Install prerequisites for cloud build.
  release-staging  Release the cloud provider images.

Deploy clusters with capz
  deploy-workload-cluster  Deploy a workload cluster with CAPZ.
  delete-workload-cluster  Delete a CAPZ workload cluster.

Tools
  golangci-lint    Download golangci-lint locally if necessary.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 7, 2026
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 7, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 7, 2026
@k8s-ci-robot k8s-ci-robot requested a review from JoelSpeed January 7, 2026 16:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mboersma
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from mainred January 7, 2026 16:06

.PHONY: manifest-node-manager-images-windows-hpc
manifest-node-manager-image-windows-hpc:
manifest-node-manager-image-windows-hpc: ## Create and push Windows HPC node-manager manifest.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks it does not match L347. could you please help update it in this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed line 347 to image instead of images so they match.

@mboersma
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2026

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-kubeadm bc074f1 link true /test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-kubeadm
pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz bc074f1 link true /test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants