-
Notifications
You must be signed in to change notification settings - Fork 306
Fix help messages for Makefile targets #9813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| .PHONY: manifest-node-manager-images-windows-hpc | ||
| manifest-node-manager-image-windows-hpc: | ||
| manifest-node-manager-image-windows-hpc: ## Create and push Windows HPC node-manager manifest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks it does not match L347. could you please help update it in this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed line 347 to image instead of images so they match.
527cb04 to
bc074f1
Compare
|
/retest |
|
@mboersma: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Updates several Makefile targets so their
make helpmessages are shown.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Before:
After:
Does this PR introduce a user-facing change?