Skip to content

make loadbalancer tunnel protocol aware#229

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
aojea:forward_udp
Apr 17, 2025
Merged

make loadbalancer tunnel protocol aware#229
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
aojea:forward_udp

Conversation

@aojea
Copy link
Copy Markdown
Contributor

@aojea aojea commented Apr 17, 2025

We were only tunneling TCP but seems UDP is also a requested feature

Change-Id: I04adae38af0befe33f22e2d36c18fbdea59e45b5
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from stmcginnis April 17, 2025 14:59
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2025
@stmcginnis
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit c6d6c2b into kubernetes-sigs:main Apr 17, 2025
5 of 7 checks passed
@aojea
Copy link
Copy Markdown
Contributor Author

aojea commented Apr 17, 2025

@stmcginnis lol, I didn't tested, I do not know if it works :)

@stmcginnis
Copy link
Copy Markdown
Contributor

Doh, I guess I should have asked first!

Should we revert? Or do you want to test and follow up with any corrections?

@aojea
Copy link
Copy Markdown
Contributor Author

aojea commented Apr 17, 2025

Should we revert? Or do you want to test and follow up with any corrections?

do you have. mac to test this?

I'm trying to see if I can add automated testing in #230

@stmcginnis
Copy link
Copy Markdown
Contributor

Unfortunately no, only access to Linux environments at the moment.

@BenTheElder
Copy link
Copy Markdown
Member

I forget: can we tunnel all? What about our friend SCTP?

@aojea
Copy link
Copy Markdown
Contributor Author

aojea commented Apr 18, 2025

I forget: can we tunnel all? What about our friend SCTP?

That's not used out of very niche cases, I will be surprised someone uses it in Mac or windows, or if those platforms even support it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants