-
Notifications
You must be signed in to change notification settings - Fork 599
🐛 Ensure node role and fargate policies are included in IAM bootstrap permissions #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @adammw. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds the possible policies needed to the
iam:GetPolicy
condition, otherwise reconciliation will fail to fetch the policy when ensuring its attachment.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5254
Special notes for your reviewer:
This requires all custom
extraPolicyAttachments
to be known at the bootstrap time. A wildcardiam:GetPolicy
may be preferable, or changing the logic of how policies are ensured to not require theGetPolicy
permission altogether (see #5266).Checklist:
Release note: