-
Notifications
You must be signed in to change notification settings - Fork 650
🐛 fix: Update OIDC provider thumbprint for EKS domains on mismatch #5827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🐛 fix: Update OIDC provider thumbprint for EKS domains on mismatch #5827
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Minh-Ng. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8002bd0 to
aa94bb5
Compare
AndiDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
|
LGTM label has been added. DetailsGit tree hash: d7c6af2f2fba8278f5c087d8428d5391d27a4953 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Added automatic thumbprint update for AWS EKS domains (oidc.eks.*.amazonaws.com). At this point AssociateOIDCProvider is true and the thumbprint was verified for a trusted domain via TLS.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5565
Special notes for your reviewer:
Checklist:
Release note: