-
Notifications
You must be signed in to change notification settings - Fork 650
🌱 refactor: drop obsolete pending e2e tests #5829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 refactor: drop obsolete pending e2e tests #5829
Conversation
Signed-off-by: arpit529srivastava <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @Arpit529Srivastava! |
|
Hi @Arpit529Srivastava. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @richardcase PTAL. |
|
/lgtm I guess @richardcase might know something about the cost topic? |
|
LGTM label has been added. DetailsGit tree hash: 40caddafccb045ddc0aaf430534492ccaa83f7d8 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
this pr removes two long-standing
pdescribe(pending) e2e tests: the dedicated hosts cluster test, which was removed due to the high cost of dedicated hosts and the absence of a required template and the vpc peering tesst, which was removed because it covered a complex setup involving vpc peering, internal elbs and external security groups that is better handled by simpler and more maintainable tests (eg, inunmanaged_functional_clusterclass_test.go). it also cleans up unused help_addresses #5176
Special notes for your reviewer:
Checklist:
Release note: