🌱 test(api): cover additionalTags keys with spaces

[alliasgher]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The existing no errors - spaces allowed test in api/v1beta1/tags_test.go and api/v1beta2/tags_test.go only exercises a tag value containing a space ({"validKey": "valid Value"}). Keys with spaces — the actual scenario reported in #4642 (e.g. Patch Group: nopatch) — are not covered, even though the regex ^[a-zA-Z0-9\s\_\.\:\=\+\-\@\/]*$ is meant to allow them.

This PR adds a regression case that uses "Patch Group" as the key in both v1beta1 and v1beta2 test tables, so future regex churn cannot silently re-break this scenario.

The actual validation regex was fixed in commit 4b69599 (Sept 2022) and ships in all currently supported v2.x releases, so no production code change is needed; this is just locking down the behaviour.

Which issue(s) this PR fixes:
Fixes #4642

Special notes for your reviewer:

I verified the regex behaviour manually and via the new test cases — both v1beta1 and v1beta2 Tags.Validate() accept keys with spaces today.

AI Usage:
Used Claude to summarise the regex history and draft the test cases; verified by running go test ./api/v1beta1/ ./api/v1beta2/ -run TestTagsValidate locally.

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @alliasgher!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @alliasgher. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[richardcase]

/ok-to-test