馃尡 Scan webhook packages during manifest generation - #6185
Conversation
controller-gen's paths list omitted every */webhooks package, so no +kubebuilder:webhook markers were ever discovered and make generate never rewrote config/webhook/manifests.yaml, leaving it de facto hand-maintained.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @joshfrench. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Discovered while working on #5812: controller-gen's paths list omitted every */webhooks package, so no
+kubebuilder:webhookmarkers were ever discovered.make generatenever rewrote config/webhook/manifests.yaml, leaving it to be edited by hand.Special notes for your reviewer:
This will incur a one-time reordering of manifests.yaml as controller-gen reorders entries from their accumulated manual order.
AI Usage:
Claude used to verify I'd caught the complete list of webhook dirs and that the diff in manifest.yaml is purely to entry order, no change to the actual webhook definitions.
Checklist:
Release note:
NONE